Re: [DistroKit] [PATCH v2] firmware-imx: make sure menuconfig works correctly

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 08.06.23 11:25, Michael Olbrich wrote:
> Suboptions are only sorted into a submenu if:
>  - the suboptions depend on the menuconfig option
>  - the suboptions are listed immediately after the menuconfig option
> 
> The BAREBOX_DEPENDENCIES in the middle breaks this so move it to the
> bottom of the file.
> 
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Thanks for the explanation!

> ---
> 
> I've updated the commit message. It should make more sense now.
> 
> Michael
> 
>  configs/platform-v8a/platforms/firmware-imx.in | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/configs/platform-v8a/platforms/firmware-imx.in b/configs/platform-v8a/platforms/firmware-imx.in
> index 8c76b693d257..19d89ace9821 100644
> --- a/configs/platform-v8a/platforms/firmware-imx.in
> +++ b/configs/platform-v8a/platforms/firmware-imx.in
> @@ -6,11 +6,6 @@ menuconfig FIRMWARE_IMX
>  	help
>  	  Install CODA VPU firmware files from the firmware-imx package.
>  
> -config BAREBOX_DEPENDENCIES
> -	tristate
> -	select FIRMWARE_IMX
> -	select TF_A
> -
>  if FIRMWARE_IMX
>  
>  config FIRMWARE_IMX_VPU_IMX27
> @@ -51,3 +46,9 @@ config FIRMWARE_IMX_BOOTIMAGE_IMX8
>  	  firmware used to build a boot image.
>  
>  endif
> +
> +config BAREBOX_DEPENDENCIES
> +	tristate
> +	select FIRMWARE_IMX
> +	select TF_A
> +

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |