DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: distrokit@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Michael Olbrich <m.olbrich@pengutronix.de>
Subject: [DistroKit] [PATCH v2] firmware-imx: make sure menuconfig works correctly
Date: Thu,  8 Jun 2023 11:25:28 +0200	[thread overview]
Message-ID: <20230608092528.1529283-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <6e79067d-59c5-40b7-da45-cbb00829df20@pengutronix.de>

Suboptions are only sorted into a submenu if:
 - the suboptions depend on the menuconfig option
 - the suboptions are listed immediately after the menuconfig option

The BAREBOX_DEPENDENCIES in the middle breaks this so move it to the
bottom of the file.

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
---

I've updated the commit message. It should make more sense now.

Michael

 configs/platform-v8a/platforms/firmware-imx.in | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/configs/platform-v8a/platforms/firmware-imx.in b/configs/platform-v8a/platforms/firmware-imx.in
index 8c76b693d257..19d89ace9821 100644
--- a/configs/platform-v8a/platforms/firmware-imx.in
+++ b/configs/platform-v8a/platforms/firmware-imx.in
@@ -6,11 +6,6 @@ menuconfig FIRMWARE_IMX
 	help
 	  Install CODA VPU firmware files from the firmware-imx package.
 
-config BAREBOX_DEPENDENCIES
-	tristate
-	select FIRMWARE_IMX
-	select TF_A
-
 if FIRMWARE_IMX
 
 config FIRMWARE_IMX_VPU_IMX27
@@ -51,3 +46,9 @@ config FIRMWARE_IMX_BOOTIMAGE_IMX8
 	  firmware used to build a boot image.
 
 endif
+
+config BAREBOX_DEPENDENCIES
+	tristate
+	select FIRMWARE_IMX
+	select TF_A
+
-- 
2.39.2




  reply	other threads:[~2023-06-08  9:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02 14:59 [DistroKit] [PATCH 0/7] platform-v8a: cleanup firmware rules Michael Olbrich
2023-06-02 14:59 ` [DistroKit] [PATCH 1/7] platform-v8a: cleanup barebox firmware handling Michael Olbrich
2023-06-02 16:40   ` Ahmad Fatoum
2023-06-08  9:19     ` Michael Olbrich
2023-06-02 14:59 ` [DistroKit] [PATCH 2/7] firmware-imx: move to the correct section Michael Olbrich
2023-06-02 16:41   ` Ahmad Fatoum
2023-06-02 14:59 ` [DistroKit] [PATCH 3/7] platform-v8a: move platform menu files to platforms/ Michael Olbrich
2023-06-02 16:44   ` Ahmad Fatoum
2023-06-08  9:22     ` Michael Olbrich
2023-06-08  9:27       ` Ahmad Fatoum
2023-06-02 14:59 ` [DistroKit] [PATCH 4/7] platform-v8a: simplify dts search path Michael Olbrich
2023-06-02 16:44   ` Ahmad Fatoum
2023-06-02 14:59 ` [DistroKit] [PATCH 5/7] firmware-imx: use foreach and ptx/nl Michael Olbrich
2023-06-02 16:45   ` Ahmad Fatoum
2023-06-02 14:59 ` [DistroKit] [PATCH 6/7] firmware-imx: make sure menuconfig works correctly Michael Olbrich
2023-06-02 16:38   ` Ahmad Fatoum
2023-06-08  9:25     ` Michael Olbrich [this message]
2023-06-08  9:27       ` [DistroKit] [PATCH v2] " Ahmad Fatoum
2023-06-02 14:59 ` [DistroKit] [PATCH 7/7] firmware-rockchip: " Michael Olbrich
2023-06-20 13:26 ` [DistroKit] [PATCH 0/7] platform-v8a: cleanup firmware rules Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230608092528.1529283-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox