Re: [DistroKit] [PATCH v4] platform-v8a: kernelconfig: cleanup

[Lucas Stach <l.stach@pengutronix.de>]

Am Montag, dem 29.01.2024 um 09:38 +0100 schrieb Michael Olbrich:
> Hi,
> 
> On Sat, Jan 27, 2024 at 11:58:48AM +0100, Robert Schwebel wrote:
> > On Fri, Jan 26, 2024 at 07:40:34PM +0100, Robert Schwebel wrote:
> > > Thanks, applied to next.
> > 
> > The testsuite found two issues:
> > 
> > - CONFIG_COMPACTION: You switched this off, but 'reason' claims that it
> >   should be on, and the help test for the option does also suggest that
> >   we better enable this. All of our other kernel configs for other
> >   platforms have it enabled.
> 
> Lucas, Marc, I don't remember why we disabled this. Unless you know and
> have a good reason, I'd say enable it.
> 
There is no good reason, we simply didn't look close enough. The
reasoning was that only MIGRATION is required for CMA, but we clearly
failed to consider the Kconfig help text when disabling COMPACTION.

Regards,
Lucas