From: Robert Schwebel <r.schwebel@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: distrokit@pengutronix.de,
"Holger Assmann" <h.assmann@pengutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [DistroKit] [PATCH v1] platform-v7a_sisd: sama5: platform w/out NEON extension
Date: Mon, 15 Mar 2021 10:33:12 +0100 [thread overview]
Message-ID: <20210315093312.setyxtiy4u3m6klk@pengutronix.de> (raw)
In-Reply-To: <20210312213006.lrk37yp7xrkatfyf@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1072 bytes --]
On Fri, Mar 12, 2021 at 10:30:06PM +0100, Uwe Kleine-König wrote:
> On Fri, Mar 12, 2021 at 02:55:30PM +0100, Oleksij Rempel wrote:
> > create mode 100644 configs/platform-v7a_sisd/patches/barebox-at91-stage1-2020.08.1/0001-HACK-ARM-at91-microchip-ksz9477-provide-first-stage-.patch
> > create mode 100644 configs/platform-v7a_sisd/patches/barebox-at91-stage1-2020.08.1/0002-ARM-at91-microchip-ksz9477-evb-implement-first-stage.patch
> > create mode 100644 configs/platform-v7a_sisd/patches/barebox-at91-stage1-2020.08.1/0003-fixup-HACK-ARM-at91-microchip-ksz9477-provide-first-.patch
>
> What is the good reason to have a fixup patch in a patch stack? Why not
> squash it?
The patches look a bit questionable for DistroKit. Please rework.
rsc
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 96 bytes --]
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
next prev parent reply other threads:[~2021-03-15 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 13:55 Oleksij Rempel
2021-03-12 21:30 ` Uwe Kleine-König
2021-03-15 9:33 ` Robert Schwebel [this message]
2021-03-29 9:52 ` Ahmad Fatoum
2021-03-15 11:07 ` Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315093312.setyxtiy4u3m6klk@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=distrokit@pengutronix.de \
--cc=h.assmann@pengutronix.de \
--cc=o.rempel@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox