From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH v2] v7a: kernel: Enable I/O expander driver for STM32MP135F-DK
Date: Thu, 1 Aug 2024 12:12:08 +0200 [thread overview]
Message-ID: <mj7y57r2cs4b33b3twoavxcf5o6aama46zs3tpcfdy3qyvij3l@pxbrwip6kuqg> (raw)
In-Reply-To: <1d45ce6b-4bcf-4460-82b2-e2f5eaa37d6c@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
Hello Ahmad,
On Thu, Aug 01, 2024 at 11:50:17AM +0200, Ahmad Fatoum wrote:
> On 01.08.24 00:35, Uwe Kleine-König wrote:
> > +CONFIG_PINCTRL_MCP23S08_I2C=y
> > +CONFIG_PINCTRL_MCP23S08_SPI=y
>
> Nit: We don't seem to actually need the SPI driver.
PINCTRL_MCP23S08_SPI wasn't explicitly enabled. That's a hidden symbol
enabled by
config PINCTRL_MCP23S08
...
select PINCTRL_MCP23S08_SPI if SPI_MASTER
. So not enabling this would require a kernel patch to make the SPI
variant explicitly selectable.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-08-01 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 22:35 Uwe Kleine-König
2024-08-01 9:50 ` Ahmad Fatoum
2024-08-01 10:12 ` Uwe Kleine-König [this message]
2024-08-01 10:13 ` Ahmad Fatoum
2024-08-14 7:25 ` Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mj7y57r2cs4b33b3twoavxcf5o6aama46zs3tpcfdy3qyvij3l@pxbrwip6kuqg \
--to=u.kleine-koenig@baylibre.com \
--cc=a.fatoum@pengutronix.de \
--cc=distrokit@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox