Re: [DistroKit] [PATCH v2 3/4] v8a: barebox: enable loading kernel, dtb and initrd via fastboot

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 09.06.23 12:28, Johannes Zink wrote:
> This allows to load kernel, dtb and initrd as sparse images to
> RAM-files.
> 
> While at it, also enable the acm gadget, which exposes the barebox shell
> as an USB gadget and autostart the usb gadgets.
> 
> Also expose mmc{0,1,2} as fastboot partitions and add init script to
> force barebox to detect these devices and have them available for
> fastboot.
> 
> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
> 
> ---
> 
> Changes:
> 
> v1 -> v2:
>  - worked in Ahmad's and Jan's review findings, thanks for your review:
>    - use generic names mmc{0,1,2} instead of {sd,emmc, } to allow
>      generic reuse of the fastboot partitions across multiple boards
>    - use more obvious partition names ram-{kernel,initramfs,oftree} to
>    - add init script for detecting /dev/mmc{0,1,2}
> ---
>  configs/platform-v8a/barebox-common-defaultenv/init/detect-mmcs       | 3 +++
>  configs/platform-v8a/barebox-common-defaultenv/nv/fastboot.acm        | 1 +
>  configs/platform-v8a/barebox-common-defaultenv/nv/fastboot.bbu        | 1 +
>  configs/platform-v8a/barebox-common-defaultenv/nv/fastboot.partitions | 1 +
>  configs/platform-v8a/barebox-common-defaultenv/nv/usbgadget.autostart | 1 +
>  5 files changed, 7 insertions(+)
> 
> diff --git a/configs/platform-v8a/barebox-common-defaultenv/init/detect-mmcs b/configs/platform-v8a/barebox-common-defaultenv/init/detect-mmcs
> new file mode 100755
> index 000000000000..e3433f6da09f
> --- /dev/null
> +++ b/configs/platform-v8a/barebox-common-defaultenv/init/detect-mmcs
> @@ -0,0 +1,3 @@
> +#!/bin/sh
> +
> +detect mmc0 mmc1 mmc2

We have a CI test that checks that barebox doesn't print errors. The Rock-3A
in the Pengutronix remote lab has no eMMC fitted, so detecting the MMC host
would throw an error and fail the test, I think. Did you check this?


> diff --git a/configs/platform-v8a/barebox-common-defaultenv/nv/fastboot.acm b/configs/platform-v8a/barebox-common-defaultenv/nv/fastboot.acm
> new file mode 100644
> index 000000000000..d00491fd7e5b
> --- /dev/null
> +++ b/configs/platform-v8a/barebox-common-defaultenv/nv/fastboot.acm
> @@ -0,0 +1 @@
> +1
> diff --git a/configs/platform-v8a/barebox-common-defaultenv/nv/fastboot.bbu b/configs/platform-v8a/barebox-common-defaultenv/nv/fastboot.bbu
> new file mode 100644
> index 000000000000..d00491fd7e5b
> --- /dev/null
> +++ b/configs/platform-v8a/barebox-common-defaultenv/nv/fastboot.bbu
> @@ -0,0 +1 @@
> +1
> diff --git a/configs/platform-v8a/barebox-common-defaultenv/nv/fastboot.partitions b/configs/platform-v8a/barebox-common-defaultenv/nv/fastboot.partitions
> new file mode 100644
> index 000000000000..527925e1c58b
> --- /dev/null
> +++ b/configs/platform-v8a/barebox-common-defaultenv/nv/fastboot.partitions
> @@ -0,0 +1 @@
> +/dev/mmc0(mmc0)o,/dev/mmc1(mmc1)o,/dev/mmc2(mmc2)o,/tmp/ram-kernel(ram-kernel)c,/tmp/ram-initramfs(ram-initramfs)c,/tmp/ram-oftree(ram-oftree)c
> diff --git a/configs/platform-v8a/barebox-common-defaultenv/nv/usbgadget.autostart b/configs/platform-v8a/barebox-common-defaultenv/nv/usbgadget.autostart
> new file mode 100644
> index 000000000000..d00491fd7e5b
> --- /dev/null
> +++ b/configs/platform-v8a/barebox-common-defaultenv/nv/usbgadget.autostart
> @@ -0,0 +1 @@
> +1
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |