Re: [DistroKit] [PATCH 3/3] v7a: stm32mp1: autostart usb fastboot and ACM gadget on AM335x boards

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Johannes,

On 24.03.23 19:28, Johannes Zink wrote:
> This allows the board to be booted by supplying kernel, oftree and
> initramfs over usb fastboot. This is particularly useful for board bringup and
> testing in situations where network boot is not possible.
> 
> Also, it may be used to flash the SD card or eMMC.
> 
> While at it: also enable the ACM USB Gadget, which exposes a serial
> console over USB and enable OEM commands.
> 
> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
> ---
>  configs/platform-v7a/barebox-stm32mp-defaultenv/nv/fastboot.bbu | 1 +
>  .../barebox-stm32mp-defaultenv/nv/fastboot.partitions           | 1 +
>  .../barebox-stm32mp-defaultenv/nv/global.usbgadget.autostart    | 1 +
>  configs/platform-v7a/barebox-stm32mp.config                     | 2 +-
>  configs/platform-v7a/barebox-stm32mp.config.diff                | 1 -
>  5 files changed, 4 insertions(+), 2 deletions(-)
>  create mode 100644 configs/platform-v7a/barebox-stm32mp-defaultenv/nv/fastboot.bbu
>  create mode 100644 configs/platform-v7a/barebox-stm32mp-defaultenv/nv/fastboot.partitions
>  create mode 100644 configs/platform-v7a/barebox-stm32mp-defaultenv/nv/global.usbgadget.autostart
> 
> diff --git a/configs/platform-v7a/barebox-stm32mp-defaultenv/nv/fastboot.bbu b/configs/platform-v7a/barebox-stm32mp-defaultenv/nv/fastboot.bbu
> new file mode 100644
> index 000000000000..d00491fd7e5b
> --- /dev/null
> +++ b/configs/platform-v7a/barebox-stm32mp-defaultenv/nv/fastboot.bbu
> @@ -0,0 +1 @@
> +1
> diff --git a/configs/platform-v7a/barebox-stm32mp-defaultenv/nv/fastboot.partitions b/configs/platform-v7a/barebox-stm32mp-defaultenv/nv/fastboot.partitions
> new file mode 100644
> index 000000000000..6f45b2161843
> --- /dev/null
> +++ b/configs/platform-v7a/barebox-stm32mp-defaultenv/nv/fastboot.partitions
> @@ -0,0 +1 @@
> +/dev/mmc0(sd)o,/dev/mmc1(mmc),/kernel(kernel)c,/initramfs(initramfs)c,/oftree(oftree)c

The MC1 and EV1 have an eMMC, but the DK1/DK2 doesn't. Should we make mmc optional?

Nitpick: I'd have preferred emmc instead of mmc, because mmc is sometimes used
to refer to both (e.g. in the names of the barebox /dev files).

> diff --git a/configs/platform-v7a/barebox-stm32mp-defaultenv/nv/global.usbgadget.autostart b/configs/platform-v7a/barebox-stm32mp-defaultenv/nv/global.usbgadget.autostart
> new file mode 100644
> index 000000000000..d00491fd7e5b
> --- /dev/null
> +++ b/configs/platform-v7a/barebox-stm32mp-defaultenv/nv/global.usbgadget.autostart
> @@ -0,0 +1 @@
> +1
> diff --git a/configs/platform-v7a/barebox-stm32mp.config b/configs/platform-v7a/barebox-stm32mp.config
> index 8a6f6d9474d2..1366849a85a2 100644
> --- a/configs/platform-v7a/barebox-stm32mp.config
> +++ b/configs/platform-v7a/barebox-stm32mp.config
> @@ -219,7 +219,7 @@ CONFIG_EXTERNAL_DTS_FRAGMENTS=""
>  # Android Fastboot
>  #
>  # CONFIG_FASTBOOT_SPARSE is not set

Can you enable sparse support? Flashing without it can be quite slow.

> -# CONFIG_FASTBOOT_CMD_OEM is not set
> +CONFIG_FASTBOOT_CMD_OEM=y
>  # end of Android Fastboot
>  # end of General Settings
>  
> diff --git a/configs/platform-v7a/barebox-stm32mp.config.diff b/configs/platform-v7a/barebox-stm32mp.config.diff
> index 42950765f911..1ec6300e636d 100644
> --- a/configs/platform-v7a/barebox-stm32mp.config.diff
> +++ b/configs/platform-v7a/barebox-stm32mp.config.diff
> @@ -49,7 +49,6 @@ CONFIG_DRIVER_SERIAL_STM32=y
>  # CONFIG_DRIVER_SPI_LITEX_SPIFLASH is undefined
>  CONFIG_EEPROM_AT24=y
>  # CONFIG_EEPROM_AT25 is undefined
> -# CONFIG_FASTBOOT_CMD_OEM is not set
>  # CONFIG_FASTBOOT_SPARSE is not set
>  # CONFIG_FIRMWARE_ALTERA_SERIAL is undefined
>  # CONFIG_FS_JFFS2 is undefined

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |