From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH v2] v7a: kernel: Enable I/O expander driver for STM32MP135F-DK
Date: Thu, 1 Aug 2024 12:13:09 +0200 [thread overview]
Message-ID: <c9ef133b-8015-4655-994f-656429729a13@pengutronix.de> (raw)
In-Reply-To: <mj7y57r2cs4b33b3twoavxcf5o6aama46zs3tpcfdy3qyvij3l@pxbrwip6kuqg>
On 01.08.24 12:12, Uwe Kleine-König wrote:
> Hello Ahmad,
>
> On Thu, Aug 01, 2024 at 11:50:17AM +0200, Ahmad Fatoum wrote:
>> On 01.08.24 00:35, Uwe Kleine-König wrote:
>>> +CONFIG_PINCTRL_MCP23S08_I2C=y
>>> +CONFIG_PINCTRL_MCP23S08_SPI=y
>>
>> Nit: We don't seem to actually need the SPI driver.
>
> PINCTRL_MCP23S08_SPI wasn't explicitly enabled. That's a hidden symbol
> enabled by
>
> config PINCTRL_MCP23S08
> ...
> select PINCTRL_MCP23S08_SPI if SPI_MASTER
>
> . So not enabling this would require a kernel patch to make the SPI
> variant explicitly selectable.
Ok, thanks for checking.
In this case, the patch looks good to me, no nits.
Cheers,
Ahmad
>
> Best regards
> Uwe
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-08-01 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 22:35 Uwe Kleine-König
2024-08-01 9:50 ` Ahmad Fatoum
2024-08-01 10:12 ` Uwe Kleine-König
2024-08-01 10:13 ` Ahmad Fatoum [this message]
2024-08-14 7:25 ` Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9ef133b-8015-4655-994f-656429729a13@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=distrokit@pengutronix.de \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox