Re: [DistroKit] [PATCH v1 5/9] mips/mipsel: barebox: use CONSOLE_ACTIVATE_NONE

[Robert Schwebel <r.schwebel@pengutronix.de>]

Hi Ahmad,

On Wed, Aug 21, 2024 at 12:07:00PM +0200, Ahmad Fatoum wrote:
> On 21.08.24 11:51, Oleksij Rempel wrote:
> > For system booting with device tree, the default console should be
> > specifie via /chosen/stdout-path and barebox should not unconditionally
> > enable any consoles. This avoids issues with probe order
> > (CONFIG_CONSOLE_ACTIVATE_FIRST) and crosstalk with serial devices that
> > don't expect console output (CONFIG_CONSOLE_ACTIVATE_ALL).
>
> Did you test this?
>
> arch/mips/dts/qemu-malta.dts doesn't have a chosen /chosen/stdout-path,
> so this change would most likely render the console completely silent.
>
> In general, we will want to use the new CONFIG_CONSOLE_ACTIVATE_ALL_FALLBACK
> option[1]. It would enable all consoles as a fallback if none was activated
> explicitly. It hasn't hit a barebox release yet though.
>
> For Malta, barebox should probably get a /chosen/stdout-path if there's indeed
> no board code or environment activating any consoles.
>
> [1]: https://lore.barebox.org/barebox/20240730083451.2203330-1-a.fatoum@pengutronix.de/

Could you quickly add a patch on top of this series on top of next?

Genereally I don't care much about MIPS any more, and we even quickly
discussed about removing it from DistroKit in the near future. Currently
this is stopping me from merging next into master, and this is already
the case for several months - not because anything broke, but because
the tooling became more picky. Not satisfying.

rsc
-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |