DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Robert Schwebel <r.schwebel@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH] fixup! v7a: barebox: am335x-mlo: document some unusual kconfig options
Date: Fri, 12 Jul 2024 17:41:18 +0200	[thread overview]
Message-ID: <ZpFOnjQN3Qsk1P5_@pengutronix.de> (raw)
In-Reply-To: <20240712153627.58995-1-a.fatoum@pengutronix.de>

Added, next test run is ... well, running ....

On Fri, Jul 12, 2024 at 05:36:27PM +0200, Ahmad Fatoum wrote:
> v7a: barebox: restrict bsp.ref condition to applicable platforms
> 
> While barebox can be built for x86_64 and MIPS, we don't currently do so,
> so the condition in the bsp.ref shouldn't assume that all platforms
> have a barebox config.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  configs/bsp.ref | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/configs/bsp.ref b/configs/bsp.ref
> index 5b5b4a763b15..2f64107ef52a 100644
> --- a/configs/bsp.ref
> +++ b/configs/bsp.ref
> @@ -53,7 +53,9 @@ barebox_arm_optimized_string_functions:
>      needs to fit into on-chip SRAM to be able to set up DRAM and thus
>      we use the smaller C implementation instead.
>    variants:
> -    - condition: kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE']
> +    - condition: |
> +        kconfig.have_barebox_config() and
> +        kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE']
>        value: False
>      - value: True
>  
> @@ -67,7 +69,9 @@ barebox_gpt_support:
>      barebox, we only need GPT support later on in the second stage
>      barebox-am335x configuration.
>    variants:
> -    - condition: kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE']
> +    - condition: |
> +        kconfig.have_barebox_config() and
> +        kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE']
>        value: False
>      - value: True
>  
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |



      reply	other threads:[~2024-07-12 15:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 15:36 Ahmad Fatoum
2024-07-12 15:41 ` Robert Schwebel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZpFOnjQN3Qsk1P5_@pengutronix.de \
    --to=r.schwebel@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox