Re: [DistroKit] [PATCH v4] platform-v8a: kernelconfig: cleanup

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

On Sat, Jan 27, 2024 at 11:58:48AM +0100, Robert Schwebel wrote:
> On Fri, Jan 26, 2024 at 07:40:34PM +0100, Robert Schwebel wrote:
> > Thanks, applied to next.
> 
> The testsuite found two issues:
> 
> - CONFIG_COMPACTION: You switched this off, but 'reason' claims that it
>   should be on, and the help test for the option does also suggest that
>   we better enable this. All of our other kernel configs for other
>   platforms have it enabled.

Lucas, Marc, I don't remember why we disabled this. Unless you know and
have a good reason, I'd say enable it.

> - CONFIG_CRYPTO_AES is on, CONFIG_CRYPTO_AES_ARM64_CE_CCM is also on,
>   but CONFIG_CRYPTO_CCM was switched from m to off.
> 
> Was there a specific reason for that, or can we switch both back on?

CONFIG_CRYPTO_CCM is no longer needed by any driver. The correct fix is to
disable CONFIG_CRYPTO_AES_ARM64_CE_CCM instead.

> I have two patches on next that re-enable those options, which might be
> squashed into your patch.

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |