Re: [DistroKit] [PATCH v2] platform-v8a: kernelconfig: cleanup

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

On Thu, Jan 25, 2024 at 04:30:37PM +0100, Alexander Dahl wrote:
> Am Thu, Jan 25, 2024 at 04:25:47PM +0100 schrieb Michael Tretter:
> > On Thu, 25 Jan 2024 09:42:53 +0100, Michael Olbrich wrote:
> > > This is the result of a review of the whole kernel config.
> > > The options have been selected by the following rules:
> > > 
> > > In general, the kernel config is optimized to keep the kernel small. So
> > > any features that are not used at all are disabled. This includes things
> > > like extra scheduling governors that require explicit configuration to
> > > be used.
> > > 
> > > All drivers that are not used by the boards configured in DistroKit are
> > > now disabled.
> > > 
> > > If there was no other strong preference then the value from the
> > > defconfig was used.
> > > 
> > > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> > > Cc: Lucas Stach <l.stach@pengutronix.de>
> > > Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> > > ---
> > > 
> > > Changes in v2:
> > >  - reenabled CONFIG_BLK_DEV_INITRD as requested by Ahmad
> > >  - enabled CONFIG_CRYPTO_DEV_SAFEXCEL with its dependencies. It's the
> > >    only driver from Uwes list that was not already enable.
> > > 
> > >  configs/platform-v8a/kernelconfig | 2249 +++++------------------------
> > >  1 file changed, 357 insertions(+), 1892 deletions(-)
> > > 
> > > diff --git a/configs/platform-v8a/kernelconfig b/configs/platform-v8a/kernelconfig
> > > index a37fd1e62a26..8dd0a0ceb7ee 100644
> > > --- a/configs/platform-v8a/kernelconfig
> > > +++ b/configs/platform-v8a/kernelconfig
> > [...]
> > > @@ -3220,29 +2490,26 @@ CONFIG_GPIOLIB=y
> > >  CONFIG_GPIOLIB_FASTPATH_LIMIT=512
> > >  CONFIG_OF_GPIO=y
> > >  CONFIG_GPIOLIB_IRQCHIP=y
> > > -CONFIG_OF_GPIO_MM_GPIOCHIP=y
> > >  # CONFIG_DEBUG_GPIO is not set
> > >  # CONFIG_GPIO_SYSFS is not set
> > >  CONFIG_GPIO_CDEV=y
> > > -CONFIG_GPIO_CDEV_V1=y
> > > +# CONFIG_GPIO_CDEV_V1 is not set
> > 
> > Disabling CONFIG_GPIO_CDEV_V1 breaks compatibility with libgpiod < 2.0.  As
> > PTXdist currently has libgpiod 1.6.3, trying to use the gpio tools with this
> > configuration won't work. The kernel also enables CDEV_V1 by default. Given
> > that libgpiod is disabled in DistroKit, I am not sure how relevant this is.
> 
> We use DistroKit as a base layer and in our higher layers we do use the
> libgpiod command line tools as well as the library itself.  It is no
> big deal because we of course have an adapted kernelconfig anyways,
> but maybe it is nice to know for you?

It's good to know and we should definitely keep this enabled. I'm somewhat
confused, why it is disabled here in the first place. It is enabled in the
defconfig so we didn't drop it during that sync and I cannot remember
disabling it manually... Strange. But that's why we have review here :-).
I'll send a new version.

Regards,
Michael



-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |