Re: [DistroKit] [PATCH] platform-v8a: kernelconfig: cleanup

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

Thanks for the Review.

On Mon, Jan 22, 2024 at 04:01:36PM +0100, Ahmad Fatoum wrote:
> On 17.01.24 14:56, Michael Olbrich wrote:
> > -CONFIG_BLK_DEV_INITRD=y
> > -CONFIG_INITRAMFS_SOURCE=""
> > -# CONFIG_RD_GZIP is not set
> > -# CONFIG_RD_BZIP2 is not set
> > -# CONFIG_RD_LZMA is not set
> > -# CONFIG_RD_XZ is not set
> > -# CONFIG_RD_LZO is not set
> > -# CONFIG_RD_LZ4 is not set
> > -CONFIG_RD_ZSTD=y
> > +# CONFIG_BLK_DEV_INITRD is not set
> 
> We want to keep CONFIG_BLK_DEV_INITRD, so DistroKit systems can easily
> boot common distros like Debian that ship with an initramfs.

I was not aware that this is a use-case for DistroKit. I'm not sure how
that is supposed to work but fine.

> > -CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
> > +# CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE is not set
> >  # CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE is not set
> >  # CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE is not set
> >  # CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND is not set
> >  # CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE is not set
> > -# CONFIG_CPU_FREQ_DEFAULT_GOV_SCHEDUTIL is not set
> > +CONFIG_CPU_FREQ_DEFAULT_GOV_SCHEDUTIL=y
> 
> Why? The default can be changed later on, but using
> performance as default allows for faster boot.

It does? By how much?

DistroKit does not change the default later so it runs with the maximum
frequency the whole time. That is not a sane default for me.

> >  CONFIG_CMA=y
> >  # CONFIG_CMA_DEBUG is not set
> > -# CONFIG_CMA_DEBUGFS is not set
> > +CONFIG_CMA_DEBUGFS=y
> 
> I never used this. What do we need this for given that we don't enable
> graphic support?

CMA is not only used by graphics drivers. It's nice to have just in case,
just like the other debug options we've enabled.

> > -CONFIG_NET_DSA=m
> > -# CONFIG_NET_DSA_TAG_NONE is not set
> > -# CONFIG_NET_DSA_TAG_AR9331 is not set
> > -# CONFIG_NET_DSA_TAG_BRCM is not set
> > -# CONFIG_NET_DSA_TAG_BRCM_LEGACY is not set
> > -# CONFIG_NET_DSA_TAG_BRCM_PREPEND is not set
> > -# CONFIG_NET_DSA_TAG_HELLCREEK is not set
> > -# CONFIG_NET_DSA_TAG_GSWIP is not set
> > -# CONFIG_NET_DSA_TAG_DSA is not set
> > -# CONFIG_NET_DSA_TAG_EDSA is not set
> > -# CONFIG_NET_DSA_TAG_MTK is not set
> > -# CONFIG_NET_DSA_TAG_KSZ is not set
> > -CONFIG_NET_DSA_TAG_OCELOT=m
> > -CONFIG_NET_DSA_TAG_OCELOT_8021Q=m
> > -# CONFIG_NET_DSA_TAG_QCA is not set
> > -# CONFIG_NET_DSA_TAG_RTL4_A is not set
> > -# CONFIG_NET_DSA_TAG_RTL8_4 is not set
> > -# CONFIG_NET_DSA_TAG_RZN1_A5PSW is not set
> > -# CONFIG_NET_DSA_TAG_LAN9303 is not set
> > -# CONFIG_NET_DSA_TAG_SJA1105 is not set
> > -# CONFIG_NET_DSA_TAG_TRAILER is not set
> > -# CONFIG_NET_DSA_TAG_XRS700X is not set
> > -CONFIG_VLAN_8021Q=m
> > -CONFIG_VLAN_8021Q_GVRP=y
> > -CONFIG_VLAN_8021Q_MVRP=y
> > -CONFIG_LLC=m
> > +# CONFIG_BRIDGE is not set
> > +# CONFIG_NET_DSA is not set
> 
> The Espressobin has an on-board Ethernet switch, but it seems it was
> not enabled before?

I'm not sure what makes sense for the Espressobin, that's why I asked Uwe
to look at that.
But I mostly disabled this stuff, because it's not actually configured
anywhere in DistroKit.

> > -CONFIG_PCIE_ROCKCHIP=y
> > -CONFIG_PCIE_ROCKCHIP_HOST=y
> > -CONFIG_PCIE_ROCKCHIP_EP=y
> > -CONFIG_PCI_XGENE=y
> > -CONFIG_PCI_XGENE_MSI=y
> > +# CONFIG_PCIE_ROCKCHIP_HOST is not set
> > +# CONFIG_PCI_XGENE is not set
> 
> In case someone is wondering too: These are rk3399-specific. rk3568 PCI remains enabled.

Right. There were several drivers enabled that were not used by any of the
boards supported by DistroKit.

> The rest looks ok.

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |