* [DistroKit] [PATCH] v7a_noneon: barebox-at91: use ARM-optimized SHA1 implementation
@ 2024-11-08 13:57 Bastian Krause
2024-11-08 14:06 ` Robert Schwebel
2024-11-08 14:18 ` Ahmad Fatoum
0 siblings, 2 replies; 3+ messages in thread
From: Bastian Krause @ 2024-11-08 13:57 UTC (permalink / raw)
To: distrokit; +Cc: Bastian Krause
Enable the SHA1 acceleration for barebox-at91, which so far had only the
generic SHA1 implementation enabled.
Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
configs/platform-v7a_noneon/barebox-at91.config | 2 +-
configs/platform-v7a_noneon/barebox-at91.config.diff | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/configs/platform-v7a_noneon/barebox-at91.config b/configs/platform-v7a_noneon/barebox-at91.config
index 53d40be12..cdf0b1af6 100644
--- a/configs/platform-v7a_noneon/barebox-at91.config
+++ b/configs/platform-v7a_noneon/barebox-at91.config
@@ -1055,7 +1055,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y
# CONFIG_DIGEST_SHA384_GENERIC is not set
# CONFIG_DIGEST_SHA512_GENERIC is not set
# CONFIG_DIGEST_HMAC_GENERIC is not set
-# CONFIG_DIGEST_SHA1_ARM is not set
+CONFIG_DIGEST_SHA1_ARM=y
# CONFIG_DIGEST_SHA256_ARM is not set
# CONFIG_CRYPTO_KEYSTORE is not set
# end of Crypto support
diff --git a/configs/platform-v7a_noneon/barebox-at91.config.diff b/configs/platform-v7a_noneon/barebox-at91.config.diff
index 378ae1ba6..872555226 100644
--- a/configs/platform-v7a_noneon/barebox-at91.config.diff
+++ b/configs/platform-v7a_noneon/barebox-at91.config.diff
@@ -55,6 +55,7 @@ CONFIG_CONSOLE_ACTIVATE_NONE=y
CONFIG_DEBUG_AT91_UART_BASE=0xffffee00
# CONFIG_DEBUG_PBL is not set
# CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW_MENU is undefined
+CONFIG_DIGEST_SHA1_ARM=y
# CONFIG_DRIVER_NET_DSA_REALTEK is not set
# CONFIG_DRIVER_NET_KSZ8873 is not set
CONFIG_DRIVER_NET_KSZ9477=y
--
2.39.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [DistroKit] [PATCH] v7a_noneon: barebox-at91: use ARM-optimized SHA1 implementation
2024-11-08 13:57 [DistroKit] [PATCH] v7a_noneon: barebox-at91: use ARM-optimized SHA1 implementation Bastian Krause
@ 2024-11-08 14:06 ` Robert Schwebel
2024-11-08 14:18 ` Ahmad Fatoum
1 sibling, 0 replies; 3+ messages in thread
From: Robert Schwebel @ 2024-11-08 14:06 UTC (permalink / raw)
To: Bastian Krause; +Cc: distrokit
applied to next
On Fri, Nov 08, 2024 at 02:57:52PM +0100, Bastian Krause wrote:
> Enable the SHA1 acceleration for barebox-at91, which so far had only the
> generic SHA1 implementation enabled.
>
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> ---
> configs/platform-v7a_noneon/barebox-at91.config | 2 +-
> configs/platform-v7a_noneon/barebox-at91.config.diff | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configs/platform-v7a_noneon/barebox-at91.config b/configs/platform-v7a_noneon/barebox-at91.config
> index 53d40be12..cdf0b1af6 100644
> --- a/configs/platform-v7a_noneon/barebox-at91.config
> +++ b/configs/platform-v7a_noneon/barebox-at91.config
> @@ -1055,7 +1055,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y
> # CONFIG_DIGEST_SHA384_GENERIC is not set
> # CONFIG_DIGEST_SHA512_GENERIC is not set
> # CONFIG_DIGEST_HMAC_GENERIC is not set
> -# CONFIG_DIGEST_SHA1_ARM is not set
> +CONFIG_DIGEST_SHA1_ARM=y
> # CONFIG_DIGEST_SHA256_ARM is not set
> # CONFIG_CRYPTO_KEYSTORE is not set
> # end of Crypto support
> diff --git a/configs/platform-v7a_noneon/barebox-at91.config.diff b/configs/platform-v7a_noneon/barebox-at91.config.diff
> index 378ae1ba6..872555226 100644
> --- a/configs/platform-v7a_noneon/barebox-at91.config.diff
> +++ b/configs/platform-v7a_noneon/barebox-at91.config.diff
> @@ -55,6 +55,7 @@ CONFIG_CONSOLE_ACTIVATE_NONE=y
> CONFIG_DEBUG_AT91_UART_BASE=0xffffee00
> # CONFIG_DEBUG_PBL is not set
> # CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW_MENU is undefined
> +CONFIG_DIGEST_SHA1_ARM=y
> # CONFIG_DRIVER_NET_DSA_REALTEK is not set
> # CONFIG_DRIVER_NET_KSZ8873 is not set
> CONFIG_DRIVER_NET_KSZ9477=y
> --
> 2.39.5
>
>
>
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [DistroKit] [PATCH] v7a_noneon: barebox-at91: use ARM-optimized SHA1 implementation
2024-11-08 13:57 [DistroKit] [PATCH] v7a_noneon: barebox-at91: use ARM-optimized SHA1 implementation Bastian Krause
2024-11-08 14:06 ` Robert Schwebel
@ 2024-11-08 14:18 ` Ahmad Fatoum
1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2024-11-08 14:18 UTC (permalink / raw)
To: Bastian Krause, distrokit
Hello Bastian,
On 08.11.24 14:57, Bastian Krause wrote:
> Enable the SHA1 acceleration for barebox-at91, which so far had only the
> generic SHA1 implementation enabled.
This is ok, but keep in mind that the platform is called v7a_noneon
for a reason. CONFIG_SHA256_ARM=y in barebox uses NEON instructions,
which are not supported on the SAMA5D3.
Cheers,
Ahmad
>
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> ---
> configs/platform-v7a_noneon/barebox-at91.config | 2 +-
> configs/platform-v7a_noneon/barebox-at91.config.diff | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configs/platform-v7a_noneon/barebox-at91.config b/configs/platform-v7a_noneon/barebox-at91.config
> index 53d40be12..cdf0b1af6 100644
> --- a/configs/platform-v7a_noneon/barebox-at91.config
> +++ b/configs/platform-v7a_noneon/barebox-at91.config
> @@ -1055,7 +1055,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y
> # CONFIG_DIGEST_SHA384_GENERIC is not set
> # CONFIG_DIGEST_SHA512_GENERIC is not set
> # CONFIG_DIGEST_HMAC_GENERIC is not set
> -# CONFIG_DIGEST_SHA1_ARM is not set
> +CONFIG_DIGEST_SHA1_ARM=y
> # CONFIG_DIGEST_SHA256_ARM is not set
> # CONFIG_CRYPTO_KEYSTORE is not set
> # end of Crypto support
> diff --git a/configs/platform-v7a_noneon/barebox-at91.config.diff b/configs/platform-v7a_noneon/barebox-at91.config.diff
> index 378ae1ba6..872555226 100644
> --- a/configs/platform-v7a_noneon/barebox-at91.config.diff
> +++ b/configs/platform-v7a_noneon/barebox-at91.config.diff
> @@ -55,6 +55,7 @@ CONFIG_CONSOLE_ACTIVATE_NONE=y
> CONFIG_DEBUG_AT91_UART_BASE=0xffffee00
> # CONFIG_DEBUG_PBL is not set
> # CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW_MENU is undefined
> +CONFIG_DIGEST_SHA1_ARM=y
> # CONFIG_DRIVER_NET_DSA_REALTEK is not set
> # CONFIG_DRIVER_NET_KSZ8873 is not set
> CONFIG_DRIVER_NET_KSZ9477=y
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-08 14:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-08 13:57 [DistroKit] [PATCH] v7a_noneon: barebox-at91: use ARM-optimized SHA1 implementation Bastian Krause
2024-11-08 14:06 ` Robert Schwebel
2024-11-08 14:18 ` Ahmad Fatoum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox