From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Robert Schwebel <r.schwebel@pengutronix.de>,
Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "Holger Assmann" <h.assmann@pengutronix.de>,
distrokit@pengutronix.de,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [DistroKit] [PATCH v1] platform-v7a_sisd: sama5: platform w/out NEON extension
Date: Mon, 29 Mar 2021 11:52:35 +0200 [thread overview]
Message-ID: <4deae1d9-d38d-74ea-89f1-0b8b647971df@pengutronix.de> (raw)
In-Reply-To: <20210315093312.setyxtiy4u3m6klk@pengutronix.de>
On 15.03.21 10:33, Robert Schwebel wrote:
> On Fri, Mar 12, 2021 at 10:30:06PM +0100, Uwe Kleine-König wrote:
>> On Fri, Mar 12, 2021 at 02:55:30PM +0100, Oleksij Rempel wrote:
>>> create mode 100644 configs/platform-v7a_sisd/patches/barebox-at91-stage1-2020.08.1/0001-HACK-ARM-at91-microchip-ksz9477-provide-first-stage-.patch
>>> create mode 100644 configs/platform-v7a_sisd/patches/barebox-at91-stage1-2020.08.1/0002-ARM-at91-microchip-ksz9477-evb-implement-first-stage.patch
>>> create mode 100644 configs/platform-v7a_sisd/patches/barebox-at91-stage1-2020.08.1/0003-fixup-HACK-ARM-at91-microchip-ksz9477-provide-first-.patch
>>
>> What is the good reason to have a fixup patch in a patch stack? Why not
>> squash it?
>
> The patches look a bit questionable for DistroKit. Please rework.
Yes, Oleksij, please do :-)
FTR: barebox has a multi-image at91_multi_defconfig, which builds multiple boards
in one go. For the two sama5d27 boards, this includes both first stage and second
stage bootloaders.
The patches included here, require two barebox images to be built with different
configs. One minimal image (BOOT.BIN) to fit into 64k SRAM, which in turn loads
the bigger barebox image (barebox.bin) from FAT into DRAM.
What's basically missing is a PBL driver to chainload barebox.bin from the BOOT.BIN
prebootloader. This is already possible with the sama5d27, so that can be used
as reference point. SAMA5D2 and D3 have different SD host controllers, however.
Good luck!
Ahmad
>
> rsc
>
>
> _______________________________________________
> DistroKit mailing list
> DistroKit@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
next prev parent reply other threads:[~2021-03-29 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 13:55 Oleksij Rempel
2021-03-12 21:30 ` Uwe Kleine-König
2021-03-15 9:33 ` Robert Schwebel
2021-03-29 9:52 ` Ahmad Fatoum [this message]
2021-03-15 11:07 ` Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4deae1d9-d38d-74ea-89f1-0b8b647971df@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=distrokit@pengutronix.de \
--cc=h.assmann@pengutronix.de \
--cc=o.rempel@pengutronix.de \
--cc=r.schwebel@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox