Re: [DistroKit] [PATCH v1 3/5] v7a_noneon: add Microchip SAMA5D3 Ethernet Delopment System Board support

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Oleksij,

On 06.07.23 13:44, Oleksij Rempel wrote:
> Microchip Technology SAMA5D3 Ethernet Development System (EDS) Board
> (DM320114) is an MPU-based platform for evaluating Ethernet Switch and
> PHY products. Compatible Ethernet Switch and PHY Evaluation Boards
> connect to the SAMA5D3 EDS Board via either an RGMII or RMII connector.
> The Microchip Technology SAMA5D3 EDS Board is not intended for
> stand-alone use and has no Ethernet capabilities when no daughter board
> or an USB Ethernet adapter is connected.

[snip]

> diff --git a/configs/platform-v7a_noneon/barebox-at91.config b/configs/platform-v7a_noneon/barebox-at91.config
> index 584bfae..06a2d96 100644
> --- a/configs/platform-v7a_noneon/barebox-at91.config
> +++ b/configs/platform-v7a_noneon/barebox-at91.config

Unrelated: barebox NAND driver is disabled, but may be useful to enable
it in the defconfig given that the EVB has NAND.

> diff --git a/configs/platform-v7a_noneon/platforms/blspec-sama5d3-eds.in b/configs/platform-v7a_noneon/platforms/blspec-sama5d3-eds.in
> new file mode 100644
> index 0000000..54ecbf7
> --- /dev/null
> +++ b/configs/platform-v7a_noneon/platforms/blspec-sama5d3-eds.in
> @@ -0,0 +1,5 @@
> +## SECTION=blspec
> +
> +config BLSPEC_SAMA5D3_EDS
> +	tristate
> +	prompt "/loader/entries/sama5d3-eds.conf bootloader spec entry"
> diff --git a/configs/platform-v7a_noneon/platforms/image-sama5d3-eds.in b/configs/platform-v7a_noneon/platforms/image-sama5d3-eds.in

Please see commit b7a4fe185852 ("v7a: blspec: convert to ptxdist default entries").
You may be able to drop your blspec rules and files and just have the
files automatically generated.

>  BAREBOX_AT91_IMAGES := \
>          images/barebox-microchip-ksz9477-evb.img \
> -        images/barebox-microchip-ksz9477-evb-xload-mmc.img
> +        images/barebox-microchip-ksz9477-evb-xload-mmc.img \
> +        images/barebox-microchip-sama5d3-eds.img \
> +        images/barebox-microchip-sama5d3-eds-xload-mmc.img

This is out of scope for your patch, but just so you know, new versions of
the PTXdist barebox rule parse the barebox-flash-images file, so you
don't need to hardcode names. Unfortunately, AT91 is not enabled
for CONFIG_ARCH_MULTIARCH, but once that's done we could have a single
bootloader for the v7a_nonneon boards (like we already do for v8a).

Cheers,
Ahmad 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |