Re: [DistroKit] [PATCH 1/1] v8a: Add support for tq-ma93xxca

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Fabian,

On 4/22/25 11:26, Fabian Pflug wrote:
> CONFIG_IMX93 sets CONFIG_AHAB, which in turn sets CONFIG_HAB
> Not really possible to disable.

Ah, ok. Fine by me then.

>> Why not make it a proper GPT partition? I know we are not consistent
>> with that in existing boards, but for new board support, we should
>> put
>> everything into a GPT partition from the get-go.
> 
> I have no opinion about it. It was just copy & paste from all the other
> boards. Will do what the majority agrees upon.

If the majority is what's already being done, then no progress is
possible ;)

Please try describing all partitions in the GPT. If there are unforeseen
problems, we can revert back to the old scheme with a comment explaining
it. :)

>>> +Write the bootloader ``platform-v8a/images/barebox-tqma93xx.img``
>>> to USB:
>>
>> s/Write to/Upload via/
>>
>> Maybe even add the full command:
>>
>>   imx-usb-loader platform-v8a/images/barebox-tqma93xx.img
> 
> See next line on the RST:

Ah didn't read beyond the platform-v8a/ :-)

>> Thanks for including docs.
> 
> You're welcome :)
> 
> Will send a new patch later, with your and other remarks.

Thanks,
Ahmad

> 
> Fabian
> 
>>
>> Cheers,
>> Ahmad
>>
> 
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |