From: Roland Hieber <rhi@pengutronix.de>
To: distrokit@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: [DistroKit] [PATCH 2/3] ci-prepare: make return value safe
Date: Wed, 22 Oct 2025 14:29:11 +0200 [thread overview]
Message-ID: <20251022122947.241881-2-rhi@pengutronix.de> (raw)
In-Reply-To: <20251022122947.241881-1-rhi@pengutronix.de>
If ./selected_toolchain_r5 does not exist, [ -e selected_toolchain_r5 ]
will return falsely and the script will return falsely too, failing the
build. Ignore the return values by wrapping the test calls into ifs
instead of relying on short-circuit.
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
ci-prepare | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/ci-prepare b/ci-prepare
index 0bb4e58664c2..14337f14e46e 100755
--- a/ci-prepare
+++ b/ci-prepare
@@ -3,14 +3,18 @@
# version symlinked to ./p
case "${JOB_BASE_NAME}" in
*v8a*)
- [ -e selected_toolchain_r5 ] || {
+ if [ -e selected_toolchain_r5 ]; then
# store away the currently selected toolchain
- [ -e selected_toolchain ] && mv selected_toolchain selected_toolchain_ci_backup
+ if [ -e selected_toolchain ]; then
+ mv selected_toolchain selected_toolchain_ci_backup
+ fi
# create toolchain based on v7a platform, which is needed for R5 processor.
./p toolchain --platformconfig=configs/platform-v7a/platformconfig
mv selected_toolchain selected_toolchain_r5
# restore the selected toolchain, if there was one before
- [ -e selected_toolchain_ci_backup ] && mv selected_toolchain_ci_backup selected_toolchain
- }
+ if [ -e selected_toolchain_ci_backup ]; then
+ mv selected_toolchain_ci_backup selected_toolchain
+ fi
+ fi
;;
esac
--
2.47.3
next prev parent reply other threads:[~2025-10-22 12:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 12:29 [DistroKit] [PATCH 1/3] ci-prepare: use the correct ptxdist script inside Jenkins environment Roland Hieber
2025-10-22 12:29 ` Roland Hieber [this message]
2025-10-22 12:46 ` [DistroKit] [PATCH 2/3] ci-prepare: make return value safe Roland Hieber
2025-10-22 12:29 ` [DistroKit] [PATCH 3/3] ci-prepare: fix indentation Roland Hieber
2025-10-22 12:43 ` Alexander Dahl
2025-10-22 13:06 ` Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251022122947.241881-2-rhi@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=distrokit@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox