From: Alexander Dahl <ada@thorsis.com>
To: Roland Hieber <rhi@pengutronix.de>
Cc: distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH 3/3] ci-prepare: fix indentation
Date: Wed, 22 Oct 2025 14:43:33 +0200 [thread overview]
Message-ID: <20251022-unkind-frigidity-cf611c9231ae@thorsis.com> (raw)
In-Reply-To: <20251022122947.241881-3-rhi@pengutronix.de>
Hello Roland,
Am Wed, Oct 22, 2025 at 02:29:12PM +0200 schrieb Roland Hieber:
> Use tabs for indentation as anywhere else in the codebase. No functional
> change indented.
Pun indented? I mean intended? ;-)
FWIW, this patch actually has white space change only, so:
Reviewed-by: Alexander Dahl <ada@thorsis.com>
Greets
Alex
>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
> ci-prepare | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/ci-prepare b/ci-prepare
> index 14337f14e46e..4bbeb668aa4b 100755
> --- a/ci-prepare
> +++ b/ci-prepare
> @@ -2,19 +2,19 @@
> # Note: this script is sourced by Jenkins, which has the auto-detected PTXdist
> # version symlinked to ./p
> case "${JOB_BASE_NAME}" in
> - *v8a*)
> - if [ -e selected_toolchain_r5 ]; then
> - # store away the currently selected toolchain
> - if [ -e selected_toolchain ]; then
> - mv selected_toolchain selected_toolchain_ci_backup
> - fi
> - # create toolchain based on v7a platform, which is needed for R5 processor.
> - ./p toolchain --platformconfig=configs/platform-v7a/platformconfig
> - mv selected_toolchain selected_toolchain_r5
> - # restore the selected toolchain, if there was one before
> - if [ -e selected_toolchain_ci_backup ]; then
> - mv selected_toolchain_ci_backup selected_toolchain
> - fi
> - fi
> - ;;
> + *v8a*)
> + if [ -e selected_toolchain_r5 ]; then
> + # store away the currently selected toolchain
> + if [ -e selected_toolchain ]; then
> + mv selected_toolchain selected_toolchain_ci_backup
> + fi
> + # create toolchain based on v7a platform, which is needed for R5 processor.
> + ./p toolchain --platformconfig=configs/platform-v7a/platformconfig
> + mv selected_toolchain selected_toolchain_r5
> + # restore the selected toolchain, if there was one before
> + if [ -e selected_toolchain_ci_backup ]; then
> + mv selected_toolchain_ci_backup selected_toolchain
> + fi
> + fi
> + ;;
> esac
> --
> 2.47.3
>
>
next prev parent reply other threads:[~2025-10-22 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 12:29 [DistroKit] [PATCH 1/3] ci-prepare: use the correct ptxdist script inside Jenkins environment Roland Hieber
2025-10-22 12:29 ` [DistroKit] [PATCH 2/3] ci-prepare: make return value safe Roland Hieber
2025-10-22 12:46 ` Roland Hieber
2025-10-22 12:29 ` [DistroKit] [PATCH 3/3] ci-prepare: fix indentation Roland Hieber
2025-10-22 12:43 ` Alexander Dahl [this message]
2025-10-22 13:06 ` Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251022-unkind-frigidity-cf611c9231ae@thorsis.com \
--to=ada@thorsis.com \
--cc=distrokit@pengutronix.de \
--cc=rhi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox