DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: distrokit@pengutronix.de
Cc: "Jan Lübbe" <j.luebbe@pengutronix.de>,
	"Ahmad Fatoum" <a.fatoum@pengutronix.de>
Subject: [DistroKit] [PATCH] reason: make OP-TEE override truly v7a-specific
Date: Thu, 15 Aug 2024 16:06:18 +0200	[thread overview]
Message-ID: <20240815140618.774941-1-a.fatoum@pengutronix.de> (raw)

QA tool complains that optee_disable_features doesn't apply when running
the check against non-v7a platforms.

To fix this, move the override into a v7a-specific file and include
that conditionally.

Suggested-by: Jan Lübbe <j.luebbe@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 configs/bsp.ref              | 14 ++------------
 configs/platform-v7a/bsp.ref | 12 ++++++++++++
 2 files changed, 14 insertions(+), 12 deletions(-)
 create mode 100644 configs/platform-v7a/bsp.ref

diff --git a/configs/bsp.ref b/configs/bsp.ref
index 2f64107ef52a..680148dbe129 100644
--- a/configs/bsp.ref
+++ b/configs/bsp.ref
@@ -1,5 +1,7 @@
 includes:
   - file: ptxdist.ref
+  - file: platform-v7a/bsp.ref
+    condition: kconfig.have_optee_config() and kconfig.OPTEEConfig()['CFG_STM32MP13']
 
 ptxdist_debug_pci:
   description: |
@@ -33,18 +35,6 @@ kernel_initrd:
       value: True
     - value: False
 
-optee_disabled_features:
-  description: |
-    OP-TEE is used as secure monitor on STM32MP13x providing power
-    management and clock/reset control support. We don't use it as
-    part of a trusted boot setup, so we prefer debuggability over
-    reduction of the attack surface.
-  condition: kconfig.have_optee_config() and kconfig.OPTEEConfig()['CFG_STM32MP13']
-  present:
-    - CFG_DEBUG_INFO
-    - CFG_ENABLE_EMBEDDED_TESTS
-    - CFG_TEE_CORE_TA_TRACE
-
 barebox_arm_optimized_string_functions:
   description: |
     The use of assembler optimized memcpy / memset functions improves
diff --git a/configs/platform-v7a/bsp.ref b/configs/platform-v7a/bsp.ref
new file mode 100644
index 000000000000..169e555df53a
--- /dev/null
+++ b/configs/platform-v7a/bsp.ref
@@ -0,0 +1,12 @@
+optee_disabled_features:
+  description: |
+    OP-TEE is used as secure monitor on STM32MP13x providing power
+    management and clock/reset control support. We don't use it as
+    part of a trusted boot setup, so we prefer debuggability over
+    reduction of the attack surface.
+  present:
+    - CFG_DEBUG_INFO
+    - CFG_ENABLE_EMBEDDED_TESTS
+    - CFG_TEE_CORE_TA_TRACE
+
+# vim: filetype=yaml shiftwidth=2 expandtab
-- 
2.39.2




             reply	other threads:[~2024-08-15 14:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-15 14:06 Ahmad Fatoum [this message]
2024-08-15 14:46 ` Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240815140618.774941-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    --cc=j.luebbe@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox