Re: [DistroKit] [PATCH 6/6] v7a_noneon: run: really constrain the forwarded SSH port to <= 64000

[Roland Hieber <rhi@pengutronix.de>]

On Thu, Aug 01, 2024 at 01:38:19PM +0200, Ahmad Fatoum wrote:
> The variable expansion braces should have been arithmetic evaluation
> parentheses, which had the effect that the PPID was always used as a
> port number (which incidentally works fine for PPIDs < 65535).
> 
> This was fixed in configs/platform-v7a/run by commit
> fb3e1645e6b5 ("v7a: run: really constrain the forwarded SSH port to <= 64000"),
> so apply the same fix here.
> 
> Fixes: 5d2b3d23b2da ("platform-v7a_noneon: sama5: platform w/out NEON extension")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  configs/platform-v7a_noneon/run | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configs/platform-v7a_noneon/run b/configs/platform-v7a_noneon/run
> index ccdcdb91c767..0307e982a334 100755
> --- a/configs/platform-v7a_noneon/run
> +++ b/configs/platform-v7a_noneon/run
> @@ -31,10 +31,10 @@ if [ ! -e "${QEMU_EXEC}" ]; then
>  	exit 1
>  fi
>  
> -# the port to which an sshd would connect (in the emulated sysem)
> +# the port to which an sshd would connect (in the emulated system)
>  SSH_INTERNAL_PORT=22
>  # the port which QEMU opens at the host side to give access to the ${SSH_INTERNAL_PORT}
> -SSH_EXTERNAL_PORT=${QEMU_SSH_PORT:-${PPID%64000+1025}}
> +SSH_EXTERNAL_PORT=${QEMU_SSH_PORT:-$((PPID%64000+1025))}

I guess we should really divide this script up into re-usable parts so
that we don't have to fix all bugs three times… but the patches in this
series look good to me.

 - Roland

>  
>  # check if vde is available for networking
>  if [ -z "${VDE_SOCKET}" ]; then
> -- 
> 2.39.2
> 
> 
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |