Re: [DistroKit] [PATCH 1/2] mipsel: sync kernelconfig

[Roland Hieber <rhi@pengutronix.de>]

On Wed, Jul 31, 2024 at 02:10:34PM +0200, Michael Olbrich wrote:
> On Wed, Jul 31, 2024 at 11:14:34AM +0200, Roland Hieber wrote:
> > Part of the changes stem from the toolchain update (commit
> > 282b31d940f79ed01352, 2024-04-22, Ladislav Michl: "mipsel: update to
> > OSELAS.Toolchain 2023.07.1"), other parts in the kernel-malta config
> > were just out of sync with the main kernelconfig. Use default values for
> > all prompted options.
> > 
> > Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > ---
> >  configs/platform-mipsel/kernelconfig          |  2 +-
> >  configs/platform-mipsel/kernelconfig-malta    | 15 +++++++++----
> >  .../platform-mipsel/kernelconfig-malta.diff   | 21 +++++++++++--------
> >  3 files changed, 24 insertions(+), 14 deletions(-)
> > 
> > diff --git a/configs/platform-mipsel/kernelconfig b/configs/platform-mipsel/kernelconfig
> > index 499b7b6c1d17..176969bb7c9b 100644
> > --- a/configs/platform-mipsel/kernelconfig
> > +++ b/configs/platform-mipsel/kernelconfig
> > @@ -17,7 +17,7 @@ CONFIG_CC_HAS_ASM_GOTO_OUTPUT=y
> >  CONFIG_CC_HAS_ASM_GOTO_TIED_OUTPUT=y
> >  CONFIG_CC_HAS_ASM_INLINE=y
> >  CONFIG_CC_HAS_NO_PROFILE_FN_ATTR=y
> > -CONFIG_PAHOLE_VERSION=0
> > +CONFIG_PAHOLE_VERSION=124
> 
> This looks suspicious. This is probably a host leak. There is no
> host-pahole package. The PTXdist upstream kernel package has PAHOLE=false
> in the make opts. That seems to be missing in the mips kernel packages.

Yes, I also don't think we need a kernel.make in mips and mipsel at all,
we can just use the upstream rule. I'll send a v2.

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |