Re: [DistroKit] [PATCH] datapartition: make it selectable

[Alexander Dahl <ada@thorsis.com>]

Hello Roland,

Am Tue, Jun 11, 2024 at 12:27:56PM +0200 schrieb Roland Hieber:
> The data partition is not needed for all aspects of the system, and
> running systemd-repart to recreate it after writing a new image slows
> the debugging cycle considerably. Make it de-selectable to speed up the
> debugging process.

+1 for the general idea.

However I noticed two things when testing this:

First: The datapartition package also targetinstalls the conf files
for creating the root-B partition to /etc/repart.rc-once.d/ which is
not created now anymore.  I guess the idea of the patch was to avoid
systemd-repart, but at least the commit message claims only the data
partition create is skipped.  Maybe installing those conf files in the
datapartition package was an unfortunate mixup to begin with.

Second: this is the second package now with category
'project_specific' which shows up directly at the top level in the
menu (ptxdist menuconfig, the other one is rauc-udev).  I would
propose to use a submenu instead and move these DistroKit specific
packages over there.

Greets
Alex

> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  rules/datapartition.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/datapartition.in b/rules/datapartition.in
> index 5b8c737fb8ad..152a60633658 100644
> --- a/rules/datapartition.in
> +++ b/rules/datapartition.in
> @@ -1,7 +1,7 @@
>  ## SECTION=project_specific
>  
>  config DATAPARTITION
> -	tristate
> +	tristate "datapartition"
>  	select RC_ONCE
>  	select SYSTEMD
>  	select SYSTEMD_REPART
> -- 
> 2.39.2
> 
>