Re: [DistroKit] [PATCH 2/3] tf-a-stm32mp13: use _URL and _SOURCE from tf-a

[Alexander Dahl <ada@thorsis.com>]

Hei hei,

Am Fri, May 03, 2024 at 12:58:43PM +0200 schrieb Michael Olbrich:
> It's already the same source since version and md5 a shared. So make
> sure the exact same file is used and downloaded only once.
> 
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> ---
>  configs/platform-v7a/rules/tf-a-stm32mp13.make | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configs/platform-v7a/rules/tf-a-stm32mp13.make b/configs/platform-v7a/rules/tf-a-stm32mp13.make
> index d8a7e92de073..137dc8de3204 100644
> --- a/configs/platform-v7a/rules/tf-a-stm32mp13.make
> +++ b/configs/platform-v7a/rules/tf-a-stm32mp13.make
> @@ -19,8 +19,8 @@ TF_A_STM32MP13_VERSION		:= $(call ptx/config-version, PTXCONF_TF_A)
>  TF_A_STM32MP13_MD5		:= $(call ptx/config-md5, PTXCONF_TF_A)
>  TF_A_STM32MP13			:= tf-a-stm32mp13-$(TF_A_STM32MP13_VERSION)
>  TF_A_STM32MP13_SUFFIX		:= tar.gz
> -TF_A_STM32MP13_URL		:= https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/snapshot/$(TF_A_STM32MP13_VERSION).$(TF_A_STM32MP13_SUFFIX)
> -TF_A_STM32MP13_SOURCE		:= $(SRCDIR)/$(TF_A_STM32MP13).$(TF_A_STM32MP13_SUFFIX)
> +TF_A_STM32MP13_URL		 = $(TF_A_URL)
> +TF_A_STM32MP13_SOURCE		 = $(TF_A_SOURCE)

As stated before: this does only work if TF_A is enabled in
platformconfig.  It will still break if TF_A_STM32MP13 is enabled, but TF_A
is not.  (This was already broken in that way before this change.)

Greets
Alex

>  TF_A_STM32MP13_DIR		:= $(BUILDDIR)/$(TF_A_STM32MP13)
>  TF_A_STM32MP13_BUILDDIR		:= $(TF_A_STM32MP13_DIR)/build
>  TF_A_STM32MP13_BUILD_OOT	:= YES
> -- 
> 2.39.2
> 
>