DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Robert Schwebel <r.schwebel@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>
Cc: distrokit@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [DistroKit]  [PATCH] v7a: barebox-stm32mp1: pass root=PARTUUID=… to kernel
Date: Tue, 12 Dec 2023 18:58:39 +0100	[thread overview]
Message-ID: <20231212175839.GW1528860@pengutronix.de> (raw)
In-Reply-To: <20231211093758.4021931-1-rhi@pengutronix.de>

Applied to next.

On Mon, Dec 11, 2023 at 10:37:58AM +0100, Roland Hieber wrote:
> This partly reverts commit e0ca556db7983a99acc3330dc32cdae395e84003.
> 
> As Ahmad reports, the kernel device tree of STM32MP157C-EV1 has no
> aliases at all, which is a precondition for enabling MMCBLKDEV_ROOTARG
> in barebox. Restore the old state which detects the PARTUUID of the root
> partition and passes it to the kernel.
> 
> Link: https://lore.distrokit.org/distrokit/9afb1d8a-f90d-7d74-781d-c33f6b7a2efb@pengutronix.de
> Fixes: e0ca556db7983a99acc3 (2023-10-20, "v7a: barebox: pass root=mmcblkXpN instead of root=PARTUUID=… to kernel")
> Reported-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  configs/platform-v7a/barebox-stm32mp.config      | 2 +-
>  configs/platform-v7a/barebox-stm32mp.config.diff | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/configs/platform-v7a/barebox-stm32mp.config b/configs/platform-v7a/barebox-stm32mp.config
> index c9cb065ce3e1..76f051a68bb1 100644
> --- a/configs/platform-v7a/barebox-stm32mp.config
> +++ b/configs/platform-v7a/barebox-stm32mp.config
> @@ -171,7 +171,7 @@ CONFIG_BOOTM_OFTREE_UIMAGE=y
>  # CONFIG_BOOTM_FITIMAGE is not set
>  CONFIG_BLSPEC=y
>  CONFIG_FLEXIBLE_BOOTARGS=y
> -CONFIG_MMCBLKDEV_ROOTARG=y
> +# CONFIG_MMCBLKDEV_ROOTARG is not set
>  CONFIG_BAREBOX_UPDATE=y
>  CONFIG_SYSTEM_PARTITIONS=y
>  CONFIG_IMD=y
> diff --git a/configs/platform-v7a/barebox-stm32mp.config.diff b/configs/platform-v7a/barebox-stm32mp.config.diff
> index 3a4ebf51a091..f1511064ff62 100644
> --- a/configs/platform-v7a/barebox-stm32mp.config.diff
> +++ b/configs/platform-v7a/barebox-stm32mp.config.diff
> @@ -82,6 +82,7 @@ CONFIG_MFD_STM32_TIMERS=y
>  CONFIG_MFD_STPMIC1=y
>  CONFIG_MFD_SYSCON=y
>  CONFIG_MICREL_PHY=y
> +# CONFIG_MMCBLKDEV_ROOTARG is not set
>  # CONFIG_MTD is not set
>  # CONFIG_MTD_CONCAT is undefined
>  # CONFIG_MTD_DATAFLASH is undefined
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |



  reply	other threads:[~2023-12-12 17:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20  9:05 [DistroKit] [PATCH v3 1/6] v7a: image-stm32mp: use 'partition-table-type' option instead of 'gpt' Roland Hieber
2023-10-20  9:05 ` [DistroKit] [PATCH v3 2/6] images: use 'partition-table-type' option instead of 'partition-table' Roland Hieber
2023-10-20  9:05 ` [DistroKit] [PATCH v3 3/6] v7a: barebox: pass root=mmcblkXpN instead of root=PARTUUID=… to kernel Roland Hieber
2023-11-22 13:27   ` Ahmad Fatoum
2023-11-22 14:17     ` Roland Hieber
2023-11-22 14:24       ` Ahmad Fatoum
2023-12-11  9:37         ` [DistroKit] [PATCH] v7a: barebox-stm32mp1: pass " Roland Hieber
2023-12-12 17:58           ` Robert Schwebel [this message]
2023-10-20  9:05 ` [DistroKit] [PATCH v3 4/6] v7a: barebox: enable GUID Partition Table support Roland Hieber
2023-10-20  9:05 ` [DistroKit] [PATCH v3 5/6] images: remove qemu size hack Roland Hieber
2023-10-20  9:05 ` [DistroKit] [PATCH v3 6/6] images: convert to GPT format Roland Hieber
2023-10-20 10:56 ` [DistroKit] [PATCH v3 1/6] v7a: image-stm32mp: use 'partition-table-type' option instead of 'gpt' Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231212175839.GW1528860@pengutronix.de \
    --to=r.schwebel@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox