DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: distrokit@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: [DistroKit] [PATCH 2/5] v7a: images: remove redundant size specifications
Date: Mon, 26 Apr 2021 08:05:23 +0200	[thread overview]
Message-ID: <20210426060526.32029-2-rhi@pengutronix.de> (raw)
In-Reply-To: <20210426060526.32029-1-rhi@pengutronix.de>

For partitions that are filled by another image, it does not make sense
to make partitions larger or smaller than their containing file system.
In those cases, genimage can already determine the partition sizes from
the referenced images, and calculates the partition offsets accordingly,
so in most cases we don't have to keep track of the sizes at all.

(A special case is vexpress.hdimg, which needs to have an empty block at
the end as a workaround for qemu, in which case it is clearer to have
all partition sizes and offsets explicitely in the config file. So don't
touch vexpress.hdimg here.)

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 configs/platform-v7a/config/images/at91-sd.config    | 2 --
 configs/platform-v7a/config/images/beaglebone.config | 2 --
 configs/platform-v7a/config/images/gf.config         | 2 --
 configs/platform-v7a/config/images/riotboard.config  | 1 -
 configs/platform-v7a/config/images/rpi2.config       | 2 --
 configs/platform-v7a/config/images/rpi3.config       | 2 --
 configs/platform-v7a/config/images/rpicm3.config     | 2 --
 configs/platform-v7a/config/images/sabrelite.config  | 1 -
 configs/platform-v7a/config/images/stm32mp.config    | 1 -
 configs/platform-v7a/config/images/udoo-neo.config   | 1 -
 10 files changed, 16 deletions(-)

diff --git a/configs/platform-v7a/config/images/at91-sd.config b/configs/platform-v7a/config/images/at91-sd.config
index 6108a20b601d..641db071224f 100644
--- a/configs/platform-v7a/config/images/at91-sd.config
+++ b/configs/platform-v7a/config/images/at91-sd.config
@@ -13,14 +13,12 @@ image @IMAGE@ {
 	}
 	partition boot {
 		image = @IMAGE@-boot.vfat
-		size = 3M
 		partition-type = 0xc
 		bootable = true
 	}
 	partition root-A {
 		image = root.ext2
 		partition-type = 0x83
-		size = 512M
 	}
 	partition data {
 		partition-type = 0x83
diff --git a/configs/platform-v7a/config/images/beaglebone.config b/configs/platform-v7a/config/images/beaglebone.config
index d3e85f2064ff..7b1c41dfc320 100644
--- a/configs/platform-v7a/config/images/beaglebone.config
+++ b/configs/platform-v7a/config/images/beaglebone.config
@@ -13,14 +13,12 @@ image @IMAGE@ {
 	}
 	partition boot {
 		image = beaglebone-boot.vfat
-		size = 32M
 		partition-type = 0xc
 		bootable = true
 	}
 	partition root-A {
 		image = root.ext2
 		partition-type = 0x83
-		size = 512M
 	}
 	partition data {
 		partition-type = 0x83
diff --git a/configs/platform-v7a/config/images/gf.config b/configs/platform-v7a/config/images/gf.config
index 0b46c215b472..fbaddf15f527 100644
--- a/configs/platform-v7a/config/images/gf.config
+++ b/configs/platform-v7a/config/images/gf.config
@@ -13,14 +13,12 @@ image @IMAGE@ {
 	}
 	partition boot {
 		image = gf-boot.vfat
-		size = 32M
 		partition-type = 0xc
 		bootable = true
 	}
 	partition root-A {
 		image = root.ext2
 		partition-type = 0x83
-		size = 512M
 	}
 	partition data {
 		partition-type = 0x83
diff --git a/configs/platform-v7a/config/images/riotboard.config b/configs/platform-v7a/config/images/riotboard.config
index fff1f6081aba..9558af38583a 100644
--- a/configs/platform-v7a/config/images/riotboard.config
+++ b/configs/platform-v7a/config/images/riotboard.config
@@ -13,7 +13,6 @@ image @IMAGE@ {
 	partition root-A {
 		image = root.ext2
 		partition-type = 0x83
-		size = 512M
 	}
 	partition data {
 		partition-type = 0x83
diff --git a/configs/platform-v7a/config/images/rpi2.config b/configs/platform-v7a/config/images/rpi2.config
index 3e45e1af5e54..f8da7d412e87 100644
--- a/configs/platform-v7a/config/images/rpi2.config
+++ b/configs/platform-v7a/config/images/rpi2.config
@@ -13,14 +13,12 @@ image @IMAGE@ {
 	}
 	partition boot {
 		image = rpi2-boot.vfat
-		size = 32M
 		partition-type = 0xc
 		bootable = true
 	}
 	partition root-A {
 		image = root.ext2
 		partition-type = 0x83
-		size = 512M
 	}
 	partition data {
 		partition-type = 0x83
diff --git a/configs/platform-v7a/config/images/rpi3.config b/configs/platform-v7a/config/images/rpi3.config
index 7bd1dae8dc46..f87a72743b4d 100644
--- a/configs/platform-v7a/config/images/rpi3.config
+++ b/configs/platform-v7a/config/images/rpi3.config
@@ -13,14 +13,12 @@ image @IMAGE@ {
 	}
 	partition boot {
 		image = rpi3-boot.vfat
-		size = 32M
 		partition-type = 0xc
 		bootable = true
 	}
 	partition root-A {
 		image = root.ext2
 		partition-type = 0x83
-		size = 512M
 	}
 	partition data {
 		partition-type = 0x83
diff --git a/configs/platform-v7a/config/images/rpicm3.config b/configs/platform-v7a/config/images/rpicm3.config
index 4c10ac4917ca..d0c4c5959e3b 100644
--- a/configs/platform-v7a/config/images/rpicm3.config
+++ b/configs/platform-v7a/config/images/rpicm3.config
@@ -13,14 +13,12 @@ image @IMAGE@ {
 	}
 	partition boot {
 		image = rpicm3-boot.vfat
-		size = 32M
 		partition-type = 0xc
 		bootable = true
 	}
 	partition root-A {
 		image = root.ext2
 		partition-type = 0x83
-		size = 512M
 	}
 	partition data {
 		partition-type = 0x83
diff --git a/configs/platform-v7a/config/images/sabrelite.config b/configs/platform-v7a/config/images/sabrelite.config
index df979d6fa22c..6fe4da7d9113 100644
--- a/configs/platform-v7a/config/images/sabrelite.config
+++ b/configs/platform-v7a/config/images/sabrelite.config
@@ -13,7 +13,6 @@ image @IMAGE@ {
 	partition root-A {
 		image = root.ext2
 		partition-type = 0x83
-		size = 512M
 	}
 	partition data {
 		partition-type = 0x83
diff --git a/configs/platform-v7a/config/images/stm32mp.config b/configs/platform-v7a/config/images/stm32mp.config
index cbf965812626..eb6065c64c1a 100644
--- a/configs/platform-v7a/config/images/stm32mp.config
+++ b/configs/platform-v7a/config/images/stm32mp.config
@@ -21,7 +21,6 @@ image @IMAGE@ {
 	}
 	partition root {
 		image = root.ext2
-		size = 512M
 	}
 	partition data {
 		size = 100M
diff --git a/configs/platform-v7a/config/images/udoo-neo.config b/configs/platform-v7a/config/images/udoo-neo.config
index de5aae9be331..6a3a8eb1eb69 100644
--- a/configs/platform-v7a/config/images/udoo-neo.config
+++ b/configs/platform-v7a/config/images/udoo-neo.config
@@ -13,7 +13,6 @@ image @IMAGE@ {
 	partition root-A {
 		image = root.ext2
 		partition-type = 0x83
-		size = 512M
 	}
 	partition data {
 		partition-type = 0x83
-- 
2.29.2


_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de


  reply	other threads:[~2021-04-26  6:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26  6:05 [DistroKit] [PATCH 1/5] v7a: image-vexpress: convert hex numbers to human-readable sizes Roland Hieber
2021-04-26  6:05 ` Roland Hieber [this message]
2021-04-26  6:35   ` [DistroKit] [PATCH 2/5] v7a: images: remove redundant size specifications Robert Schwebel
2021-04-26  6:05 ` [DistroKit] [PATCH 3/5] v7a: barebox: clean up defaultenvs Roland Hieber
2021-04-26  6:36   ` Robert Schwebel
2021-04-26  6:05 ` [DistroKit] [PATCH 4/5] v7a: run: remove telnet port forwarding Roland Hieber
2021-04-26  6:36   ` Robert Schwebel
2021-04-26  6:05 ` [DistroKit] [PATCH 5/5] v7a: run: randomise the SSH forwarding port Roland Hieber
2021-04-26  6:33   ` Michael Olbrich
2021-04-26  8:30     ` Roland Hieber
2021-04-26  8:35       ` [DistroKit] [PATCH v2] " Roland Hieber
2021-04-26  9:02         ` Robert Schwebel
2021-04-26  9:03           ` Robert Schwebel
2021-04-26 10:07   ` [DistroKit] [PATCH v3] v7a: run: make the SSH forwarding port multiprocess-compatible Roland Hieber
2021-04-26 10:09     ` Robert Schwebel
2021-04-26  6:35 ` [DistroKit] [PATCH 1/5] v7a: image-vexpress: convert hex numbers to human-readable sizes Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210426060526.32029-2-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox