Re: [DistroKit] [PATCH] unfs3: Fix generation of export list

[Roland Hieber <rhi@pengutronix.de>]

On Thu, Mar 11, 2021 at 06:38:49PM +0100, Uwe Kleine-König wrote:
> Before this change the content of the export list is by default:
> 
> 	/ (rw,no_root_squash),insecure
> 
> which is wrong. The closing parenthesis must be after the insecure
> keyword.
> 
> It seems I'm the first user of unfs3 in the v7a platform since 2016.

Hmm, why do we need this file at all? Shouldn't this be included in
upstream PTXdist too?

 - Roland

> Fixes: c17c88e05a88 ("platform: beaglebone: nfs: add insecure option")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  configs/platform-v7a/scripts/lib/ptxd_make_nfsd.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/platform-v7a/scripts/lib/ptxd_make_nfsd.sh b/configs/platform-v7a/scripts/lib/ptxd_make_nfsd.sh
> index 5a95628b5324..58f100d95f70 100644
> --- a/configs/platform-v7a/scripts/lib/ptxd_make_nfsd.sh
> +++ b/configs/platform-v7a/scripts/lib/ptxd_make_nfsd.sh
> @@ -25,7 +25,7 @@ ptxd_make_nfsd_exec() {
>      echo
>  
>      #insecure for qemu with -net user
> -    client_specifications="${client_specifications},insecure"
> +    client_specifications="${client_specifications%)},insecure)"
>      echo "/ ${client_specifications}" > "${PTXDIST_TEMPDIR}/exports" &&
>      UNFS_BASE="${base}" unfsd -e "${PTXDIST_TEMPDIR}/exports" -n ${port} -m ${port} -p -d "${@}"
>  }
> -- 
> 2.30.1
> 
> 
> _______________________________________________
> DistroKit mailing list
> DistroKit@pengutronix.de

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de