DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: distrokit@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: [DistroKit] [PATCH 2/3] mips: kernel: properly handle signed modules
Date: Sat, 10 Apr 2021 01:02:51 +0200	[thread overview]
Message-ID: <20210409230252.28738-2-rhi@pengutronix.de> (raw)
In-Reply-To: <20210409230252.28738-1-rhi@pengutronix.de>

This ports the following commits from PTXdist 2021.04.0:

    | commit a22b449946eed634f42b06b0c385b29621c6d02e
    | Author: Michael Olbrich <m.olbrich@pengutronix.de>
    | Date:   2021-04-01 15:58:54
    |
    |     template: kernel: proper handle signed modules
    |
    |     Same as 565aabf6f36d3ed31544d882394604c4a1b13597 but for the kernel
    |     template instead of the kernel itself.
    |
    |     Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
    |
    | commit 565aabf6f36d3ed31544d882394604c4a1b13597
    | Author: Denis Osterland-Heim <denis.osterland@diehl.com>
    | Date:   2021-03-31 13:35:25
    |
    |     kernel: proper handle signed modules
    |
    |     If CONFIG_MODULE_SIG_ALL is set in kernelconfig then modules will be
    |     automatically signed during the modules_install phase of a kernel build.
    |
    |     Signed modules are BRITTLE as the signature is outside of the defined ELF
    |     container. Thus they MAY NOT be stripped once the signature is computed
    |     and attached. Note the entire module is the signed payload, including any
    |     and all debug information present at the time of signing.
    |
    |     See: https://www.kernel.org/doc/html/latest/admin-guide/module-signing.html
    |     Signed-off-by: Denis Osterland-Heim <denis.osterland@diehl.com>
    |     Message-Id: <20210331113525.22330-1-denis.osterland@diehl.com>
    |     Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>

We might not sign kernel modules at the time, but apply the principle of
least surprise and port it now to be up to date with the upstream
kernel rule template.

Link: https://git.pengutronix.de/cgit/ptxdist/commit/?id=a22b449946eed634f42b
Link: https://git.pengutronix.de/cgit/ptxdist/commit/?id=565aabf6f36d3ed31544
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 configs/platform-mips/rules/kernel-ar9331.make | 2 +-
 configs/platform-mips/rules/kernel-malta.make  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configs/platform-mips/rules/kernel-ar9331.make b/configs/platform-mips/rules/kernel-ar9331.make
index bb7ddbc25c94..98452a90a0a4 100644
--- a/configs/platform-mips/rules/kernel-ar9331.make
+++ b/configs/platform-mips/rules/kernel-ar9331.make
@@ -98,7 +98,7 @@ $(STATEDIR)/kernel-ar9331.targetinstall:
 	@$(call install_copy, kernel-ar9331, 0, 0, 0644, \
 		$(IMAGEDIR)/vmlinuz-ar9331, /boot/vmlinuz-ar9331, n)
 
-	@$(call install_glob, kernel-ar9331, 0, 0, -, /lib/modules, *.ko,, k)
+	@$(call install_glob, kernel-ar9331, 0, 0, -, /lib/modules, *.ko,, n)
 	@$(call install_glob, kernel-ar9331, 0, 0, -, /lib/modules,, *.ko */build */source, n)
 
 	@$(call install_finish, kernel-ar9331)
diff --git a/configs/platform-mips/rules/kernel-malta.make b/configs/platform-mips/rules/kernel-malta.make
index 0450e04ce690..cfb387442d41 100644
--- a/configs/platform-mips/rules/kernel-malta.make
+++ b/configs/platform-mips/rules/kernel-malta.make
@@ -98,7 +98,7 @@ $(STATEDIR)/kernel-malta.targetinstall:
 	@$(call install_copy, kernel-malta, 0, 0, 0644, \
 		$(IMAGEDIR)/vmlinuz-malta, /boot/vmlinuz-malta, n)
 
-	@$(call install_glob, kernel-malta, 0, 0, -, /lib/modules, *.ko,, k)
+	@$(call install_glob, kernel-malta, 0, 0, -, /lib/modules, *.ko,, n)
 	@$(call install_glob, kernel-malta, 0, 0, -, /lib/modules,, *.ko */build */source, n)
 
 	@$(call install_finish, kernel-malta)
-- 
2.29.2


_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de


  reply	other threads:[~2021-04-09 23:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 23:02 [DistroKit] [PATCH 1/3] ptxdist: migrate 2021.03.0 -> 2021.04.0 Roland Hieber
2021-04-09 23:02 ` Roland Hieber [this message]
2021-04-23 10:55   ` [DistroKit] [PATCH 2/3] mips: kernel: properly handle signed modules Robert Schwebel
2021-04-09 23:02 ` [DistroKit] [PATCH 3/3] barebox: set barebox build sytem version Roland Hieber
2021-04-23 10:55   ` Robert Schwebel
2021-04-23 10:54 ` [DistroKit] [PATCH 1/3] ptxdist: migrate 2021.03.0 -> 2021.04.0 Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210409230252.28738-2-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox