From: Roland Hieber <rhi@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH] v8a/firmware-imx: Ensure PKGDIR exists
Date: Tue, 16 Mar 2021 14:56:56 +0100 [thread overview]
Message-ID: <20210316135656.kfetku7fwds5njf3@pengutronix.de> (raw)
In-Reply-To: <20210316105145.1854-1-u.kleine-koenig@pengutronix.de>
On Tue, Mar 16, 2021 at 11:51:45AM +0100, Uwe Kleine-König wrote:
> This fixes:
>
> tar: DistroKit/platform-v8a/packages: Cannot open: No such file or directory
> tar: Error is not recoverable: exiting now
> make: *** [DistroKit/configs/platform-v8a/rules/firmware-imx.make:36: DistroKit/platform-v8a/state/firmware-imx.extract] Error 2
>
> e.g. when running
>
> ptxdist extract firmware-imx
>
> in an unbuilt tree.
>
> Fixes: 2e2c4377dc08 ("i.MX8M: add firmware-imx 8.8")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> configs/platform-v8a/rules/firmware-imx.make | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configs/platform-v8a/rules/firmware-imx.make b/configs/platform-v8a/rules/firmware-imx.make
> index b0efdb400611..0eae43503966 100644
> --- a/configs/platform-v8a/rules/firmware-imx.make
> +++ b/configs/platform-v8a/rules/firmware-imx.make
> @@ -33,6 +33,7 @@ FIRMWARE_IMX_SOURCE := $(SRCDIR)/$(FIRMWARE_IMX).$(FIRMWARE_IMX_SUFFIX)
>
> $(STATEDIR)/firmware-imx.extract:
> @$(call targetinfo)
> + @mkdir -p "$(PKGDIR)"
> @dd if=$(FIRMWARE_IMX_SOURCE) bs=$(FIRMWARE_IMX_SKIP) skip=1 | tar xj -C $(PKGDIR)
This looks strange. PKGDIR is the location where the files are installed
in the install stage. The extract stage should extract the source into
$(FIRMWARE_IMX_DIR), which is usually $(BUILDDIR)/$(FIRMWARE_IMX), and
$(BUILDDIR) will also be created by PTXdist during startup.
The prepare stage also doesn't so the @$(call clean, $(<PKG>_DIR)) or
@$(call patchin, <PKG>) steps, so I guess this rule needs cleanup in
general.
- Roland
--
Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
next prev parent reply other threads:[~2021-03-16 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 10:51 Uwe Kleine-König
2021-03-16 11:01 ` Robert Schwebel
2021-03-16 13:56 ` Roland Hieber [this message]
2021-03-16 14:03 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316135656.kfetku7fwds5njf3@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=distrokit@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox