DistroKit Mailinglist
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: distrokit@pengutronix.de
Subject: [DistroKit] [PATCH] unfs3: Fix generation of export list
Date: Thu, 11 Mar 2021 18:38:49 +0100	[thread overview]
Message-ID: <20210311173849.87905-1-u.kleine-koenig@pengutronix.de> (raw)

Before this change the content of the export list is by default:

	/ (rw,no_root_squash),insecure

which is wrong. The closing parenthesis must be after the insecure
keyword.

It seems I'm the first user of unfs3 in the v7a platform since 2016.

Fixes: c17c88e05a88 ("platform: beaglebone: nfs: add insecure option")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 configs/platform-v7a/scripts/lib/ptxd_make_nfsd.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/platform-v7a/scripts/lib/ptxd_make_nfsd.sh b/configs/platform-v7a/scripts/lib/ptxd_make_nfsd.sh
index 5a95628b5324..58f100d95f70 100644
--- a/configs/platform-v7a/scripts/lib/ptxd_make_nfsd.sh
+++ b/configs/platform-v7a/scripts/lib/ptxd_make_nfsd.sh
@@ -25,7 +25,7 @@ ptxd_make_nfsd_exec() {
     echo
 
     #insecure for qemu with -net user
-    client_specifications="${client_specifications},insecure"
+    client_specifications="${client_specifications%)},insecure)"
     echo "/ ${client_specifications}" > "${PTXDIST_TEMPDIR}/exports" &&
     UNFS_BASE="${base}" unfsd -e "${PTXDIST_TEMPDIR}/exports" -n ${port} -m ${port} -p -d "${@}"
 }
-- 
2.30.1


_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de

             reply	other threads:[~2021-03-11 17:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 17:38 Uwe Kleine-König [this message]
2021-03-11 17:52 ` Robert Schwebel
2021-04-25 15:30 ` Roland Hieber
2021-04-25 16:22   ` Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311173849.87905-1-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox