From: Robert Schwebel <r.schwebel@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>
Cc: distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH 3/3] image-rpi2, image-rpi3: remove no-op ptxd_replace_magic calls
Date: Tue, 9 Feb 2021 10:06:31 +0100 [thread overview]
Message-ID: <20210209090631.c6qpl5fufxxuzmrn@pengutronix.de> (raw)
In-Reply-To: <20210207235543.11784-3-rhi@pengutronix.de>
On Mon, Feb 08, 2021 at 12:55:43AM +0100, Roland Hieber wrote:
> The new 'ptxdist lint' feature complained about these lines:
>
> Undefined symbol PTXCONF_IMAGE_RPI2_GPU_MEM used in 'next/configs/platform-v7a/rules/image-rpi2.make'.
> Undefined symbol PTXCONF_IMAGE_RPI3_GPU_MEM used in 'next/configs/platform-v7a/rules/image-rpi3.make'.
>
> Indeed, these complaints were caused by multiple issues, probably going
> back to copy-and-paste from platform-rpi:
>
> * IMAGE_RPI2_GPU_MEM and IMAGE_RPI3_GPU_MEM were never defined in any
> kconfig menu since these lines were added (but a similar kconfig item
> exists in configs/platform-rpi)
> * configs/platform-v7a/rpi-firmware/config.txt didn't have any magic
> replacement markers anymore since commit 98626f8441add596486b
> * the "replaced" config.txt was never used by anything after writing it
> to PTXDIST_TEMPDIR (which is the case in configs/platform-rpi)
>
> Remove the call completely.
>
> Fixes: 1db122202276b9f343eb (2017-06-16, "platform-v7a: rpi2: add board support")
> Fixes: 98626f8441add596486b (2018-11-29, "add RPI3 Support")
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
> configs/platform-v7a/rules/image-rpi2.make | 3 ---
> configs/platform-v7a/rules/image-rpi3.make | 3 ---
> 2 files changed, 6 deletions(-)
Applied to next.
rsc
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
next prev parent reply other threads:[~2021-02-09 9:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 23:55 [DistroKit] [PATCH 1/3] ptxdist: version bump 2021.01.0 -> 2021.02.0 Roland Hieber
2021-02-07 23:55 ` [DistroKit] [PATCH 2/3] Revert "genimage: update to v14" Roland Hieber
2021-02-09 9:06 ` Robert Schwebel
2021-02-07 23:55 ` [DistroKit] [PATCH 3/3] image-rpi2, image-rpi3: remove no-op ptxd_replace_magic calls Roland Hieber
2021-02-09 9:06 ` Robert Schwebel [this message]
2021-02-09 9:05 ` [DistroKit] [PATCH 1/3] ptxdist: version bump 2021.01.0 -> 2021.02.0 Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209090631.c6qpl5fufxxuzmrn@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=distrokit@pengutronix.de \
--cc=rhi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox