* [DistroKit] [PATCH 2/3] v7a: images: stm32mp: don't quote boolean in genimage
2021-01-25 19:37 [DistroKit] [PATCH 1/3] genimage: update to v14 Ahmad Fatoum
@ 2021-01-25 19:37 ` Ahmad Fatoum
2021-02-01 17:57 ` Robert Schwebel
2021-01-25 19:37 ` [DistroKit] [PATCH 3/3] v7a: images: stm32mp: don't place backup GPT table into image Ahmad Fatoum
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Ahmad Fatoum @ 2021-01-25 19:37 UTC (permalink / raw)
To: distrokit
Both forms are accepted, but it looks more natural to not quote
non-string values. This is also what we do for the other genimage
configs (e.g. bootable = true).
---
configs/platform-v7a/config/images/stm32mp.config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/platform-v7a/config/images/stm32mp.config b/configs/platform-v7a/config/images/stm32mp.config
index c10632013127..4095e9fc612b 100644
--- a/configs/platform-v7a/config/images/stm32mp.config
+++ b/configs/platform-v7a/config/images/stm32mp.config
@@ -1,7 +1,7 @@
image @IMAGE@ {
hdimage {
align = 1M
- gpt = "true"
+ gpt = true
}
partition fsbl1 {
image = "tf-a-@STM32MP_BOARD@.stm32"
--
2.30.0
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [DistroKit] [PATCH 2/3] v7a: images: stm32mp: don't quote boolean in genimage
2021-01-25 19:37 ` [DistroKit] [PATCH 2/3] v7a: images: stm32mp: don't quote boolean in genimage Ahmad Fatoum
@ 2021-02-01 17:57 ` Robert Schwebel
0 siblings, 0 replies; 8+ messages in thread
From: Robert Schwebel @ 2021-02-01 17:57 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: distrokit
On Mon, Jan 25, 2021 at 08:37:04PM +0100, Ahmad Fatoum wrote:
> Both forms are accepted, but it looks more natural to not quote
> non-string values. This is also what we do for the other genimage
> configs (e.g. bootable = true).
> ---
> configs/platform-v7a/config/images/stm32mp.config | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thx.
rsc
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* [DistroKit] [PATCH 3/3] v7a: images: stm32mp: don't place backup GPT table into image
2021-01-25 19:37 [DistroKit] [PATCH 1/3] genimage: update to v14 Ahmad Fatoum
2021-01-25 19:37 ` [DistroKit] [PATCH 2/3] v7a: images: stm32mp: don't quote boolean in genimage Ahmad Fatoum
@ 2021-01-25 19:37 ` Ahmad Fatoum
2021-02-01 18:01 ` Robert Schwebel
2021-02-01 10:34 ` [DistroKit] [PATCH 1/3] genimage: update to v14 Ahmad Fatoum
2021-02-01 17:53 ` Robert Schwebel
3 siblings, 1 reply; 8+ messages in thread
From: Ahmad Fatoum @ 2021-01-25 19:37 UTC (permalink / raw)
To: distrokit
The images sizes don't correspond to a specific SD-Card or eMMC size,
so software checking for the backup partition table at the end of
the device won't find it.
Dropping it will however reduce the STM32MP1 images size (618M -> 66M).
Do so.
---
configs/platform-v7a/config/images/stm32mp.config | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/platform-v7a/config/images/stm32mp.config b/configs/platform-v7a/config/images/stm32mp.config
index 4095e9fc612b..e46f5a7f3c40 100644
--- a/configs/platform-v7a/config/images/stm32mp.config
+++ b/configs/platform-v7a/config/images/stm32mp.config
@@ -2,6 +2,7 @@ image @IMAGE@ {
hdimage {
align = 1M
gpt = true
+ gpt-no-backup = true
}
partition fsbl1 {
image = "tf-a-@STM32MP_BOARD@.stm32"
--
2.30.0
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [DistroKit] [PATCH 3/3] v7a: images: stm32mp: don't place backup GPT table into image
2021-01-25 19:37 ` [DistroKit] [PATCH 3/3] v7a: images: stm32mp: don't place backup GPT table into image Ahmad Fatoum
@ 2021-02-01 18:01 ` Robert Schwebel
0 siblings, 0 replies; 8+ messages in thread
From: Robert Schwebel @ 2021-02-01 18:01 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: distrokit
On Mon, Jan 25, 2021 at 08:37:05PM +0100, Ahmad Fatoum wrote:
> The images sizes don't correspond to a specific SD-Card or eMMC size,
> so software checking for the backup partition table at the end of
> the device won't find it.
>
> Dropping it will however reduce the STM32MP1 images size (618M -> 66M).
> Do so.
> ---
> configs/platform-v7a/config/images/stm32mp.config | 1 +
> 1 file changed, 1 insertion(+)
Applied, thx.
rsc
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [DistroKit] [PATCH 1/3] genimage: update to v14
2021-01-25 19:37 [DistroKit] [PATCH 1/3] genimage: update to v14 Ahmad Fatoum
2021-01-25 19:37 ` [DistroKit] [PATCH 2/3] v7a: images: stm32mp: don't quote boolean in genimage Ahmad Fatoum
2021-01-25 19:37 ` [DistroKit] [PATCH 3/3] v7a: images: stm32mp: don't place backup GPT table into image Ahmad Fatoum
@ 2021-02-01 10:34 ` Ahmad Fatoum
2021-02-01 18:01 ` Robert Schwebel
2021-02-01 17:53 ` Robert Schwebel
3 siblings, 1 reply; 8+ messages in thread
From: Ahmad Fatoum @ 2021-02-01 10:34 UTC (permalink / raw)
To: distrokit
Hello,
On 25.01.21 20:37, Ahmad Fatoum wrote:
> v14 adds support for gpt-no-backup, which allows us to shrink our GPT
> image sizes for the lxa-mc1 and stm32mp157c-dk.
>
> This commit can be reverted with the migration to ptxdist v2020.02.0.
I just noticed I forget the Signed-off-by's. I can respin if needed.
Otherwise, I'd wait util ptxdist v2020.02.0 is released and rebase
on top of a DistroKit migrated to that.
> ---
> rules/host-genimage.make | 38 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 rules/host-genimage.make
>
> diff --git a/rules/host-genimage.make b/rules/host-genimage.make
> new file mode 100644
> index 000000000000..6e4468d24bb7
> --- /dev/null
> +++ b/rules/host-genimage.make
> @@ -0,0 +1,38 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2012 by Michael Olbrich <m.olbrich@pengutronix.de>
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +HOST_PACKAGES-$(PTXCONF_HOST_GENIMAGE) += host-genimage
> +
> +#
> +# Paths and names
> +#
> +HOST_GENIMAGE_VERSION := 14
> +HOST_GENIMAGE_MD5 := 266b5692aba2e2b98db2ec9de7c09a59
> +HOST_GENIMAGE := genimage-$(HOST_GENIMAGE_VERSION)
> +HOST_GENIMAGE_SUFFIX := tar.xz
> +HOST_GENIMAGE_URL := http://www.pengutronix.de/software/genimage/download/$(HOST_GENIMAGE).$(HOST_GENIMAGE_SUFFIX)
> +HOST_GENIMAGE_SOURCE := $(SRCDIR)/$(HOST_GENIMAGE).$(HOST_GENIMAGE_SUFFIX)
> +HOST_GENIMAGE_DIR := $(HOST_BUILDDIR)/$(HOST_GENIMAGE)
> +HOST_GENIMAGE_LICENSE := GPL-2.0-only
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#
> +# autoconf
> +#
> +HOST_GENIMAGE_CONF_TOOL := autoconf
> +HOST_GENIMAGE_CONF_OPT := \
> + $(HOST_AUTOCONF) \
> + --enable-largefile
> +
> +# vim: syntax=make
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [DistroKit] [PATCH 1/3] genimage: update to v14
2021-02-01 10:34 ` [DistroKit] [PATCH 1/3] genimage: update to v14 Ahmad Fatoum
@ 2021-02-01 18:01 ` Robert Schwebel
0 siblings, 0 replies; 8+ messages in thread
From: Robert Schwebel @ 2021-02-01 18:01 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: distrokit
On Mon, Feb 01, 2021 at 11:34:44AM +0100, Ahmad Fatoum wrote:
> On 25.01.21 20:37, Ahmad Fatoum wrote:
> > v14 adds support for gpt-no-backup, which allows us to shrink our GPT
> > image sizes for the lxa-mc1 and stm32mp157c-dk.
> >
> > This commit can be reverted with the migration to ptxdist v2020.02.0.
>
> I just noticed I forget the Signed-off-by's. I can respin if needed.
> Otherwise, I'd wait util ptxdist v2020.02.0 is released and rebase
> on top of a DistroKit migrated to that.
I've added the S-o-bs while applying.
rsc
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [DistroKit] [PATCH 1/3] genimage: update to v14
2021-01-25 19:37 [DistroKit] [PATCH 1/3] genimage: update to v14 Ahmad Fatoum
` (2 preceding siblings ...)
2021-02-01 10:34 ` [DistroKit] [PATCH 1/3] genimage: update to v14 Ahmad Fatoum
@ 2021-02-01 17:53 ` Robert Schwebel
3 siblings, 0 replies; 8+ messages in thread
From: Robert Schwebel @ 2021-02-01 17:53 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: distrokit
On Mon, Jan 25, 2021 at 08:37:03PM +0100, Ahmad Fatoum wrote:
> v14 adds support for gpt-no-backup, which allows us to shrink our GPT
> image sizes for the lxa-mc1 and stm32mp157c-dk.
>
> This commit can be reverted with the migration to ptxdist v2020.02.0.
> ---
> rules/host-genimage.make | 38 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 rules/host-genimage.make
Applied, thx.
rsc
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 8+ messages in thread