From: Roland Hieber <rhi@pengutronix.de>
To: distrokit@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: [DistroKit] [PATCH 3/3] rpi: image-boot-vfat: remove unused variables
Date: Sun, 6 Dec 2020 22:48:17 +0100 [thread overview]
Message-ID: <20201206214817.15366-3-rhi@pengutronix.de> (raw)
In-Reply-To: <20201206214817.15366-1-rhi@pengutronix.de>
The variables HEADER and START were apparently meant to be used as
replacements in configs/platform-rpi/config/images/boot-vfat.config, but
they are not used nowhere Furthermore, HEADER referenced a non-existent
file, START used the non-existing Kconfig symbol IMAGE_BOOT_VFAT_START,
and was not layer-aware by using PTXDIST_PLATFORMCONFIGDIR, and
start.elf is also already referenced in FILES.
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
configs/platform-rpi/rules/image-boot-vfat.make | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/configs/platform-rpi/rules/image-boot-vfat.make b/configs/platform-rpi/rules/image-boot-vfat.make
index dac8939cbc17..2e43731fd69f 100644
--- a/configs/platform-rpi/rules/image-boot-vfat.make
+++ b/configs/platform-rpi/rules/image-boot-vfat.make
@@ -36,11 +36,9 @@ endef
IMAGE_BOOT_VFAT_ENV := \
FILES="$(call squote_and_comma,$(IMAGE_BOOT_VFAT_DATA))" \
- HEADER=$(PTXDIST_PLATFORMCONFIGDIR)/first32k.bin \
BAREBOX=barebox-image \
BAREBOX_ENV=barebox-default-environment \
- KERNEL=linuximage \
- START=$(PTXDIST_PLATFORMCONFIGDIR)/firmware/$(PTXCONF_IMAGE_BOOT_VFAT_START)_start.elf
+ KERNEL=linuximage
$(IMAGE_BOOT_VFAT_IMAGE):
@$(call targetinfo)
--
2.29.2
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
next prev parent reply other threads:[~2020-12-06 21:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 21:48 [DistroKit] [PATCH 1/3] platforms: make DTC_OFTREE_DTS_PATH layer-aware Roland Hieber
2020-12-06 21:48 ` [DistroKit] [PATCH 2/3] rpi: barebox: make BAREBOX_EXTRA_ENV_PATH layer-aware Roland Hieber
2021-02-01 17:48 ` Robert Schwebel
2020-12-06 21:48 ` Roland Hieber [this message]
2021-02-01 17:49 ` [DistroKit] [PATCH 3/3] rpi: image-boot-vfat: remove unused variables Robert Schwebel
2020-12-07 7:47 ` [DistroKit] [PATCH 1/3] platforms: make DTC_OFTREE_DTS_PATH layer-aware Alexander Dahl
2021-01-15 12:33 ` Roland Hieber
2021-01-15 12:52 ` Michael Olbrich
2021-02-01 17:46 ` Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201206214817.15366-3-rhi@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=distrokit@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox