[DistroKit] [PATCH] tf-a: Add missing dependency to host dtc

[DistroKit] [PATCH] tf-a: Add missing dependency to host dtc

[Alexander Dahl]

Build after clean all failed like this:

    /bin/sh: 1: dtc: not found
    dtc version too old (), you need at least version 1.4.4

A quick inspection of the tf-a source showed dtc is only needed for
stm32 when TF_A_EXTRA_ARGS is used, like it is done currently in
DistroKit, so a global dependency might be to broad. However dtc is
probably needed for arm targets anyway, so it should not hurt that
much?!

Signed-off-by: Alexander Dahl <post@lespocky.de>
---
 rules/tf-a.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rules/tf-a.in b/rules/tf-a.in
index 3cddf79..ba04f44 100644
--- a/rules/tf-a.in
+++ b/rules/tf-a.in
@@ -2,6 +2,7 @@
 
 menuconfig TF_A
 	select BOOTLOADER
+	select HOST_DTC
 	prompt "ARM Trusted Firmware-A        "
 	depends on ARCH_ARM || ARCH_ARM64
 	bool
-- 
2.20.1


_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de

Re: [DistroKit] [PATCH] tf-a: Add missing dependency to host dtc

[Ahmad Fatoum]

Hi,

On 3/14/20 2:05 PM, Alexander Dahl wrote:
> Build after clean all failed like this:
> 
>     /bin/sh: 1: dtc: not found
>     dtc version too old (), you need at least version 1.4.4
> 
> A quick inspection of the tf-a source showed dtc is only needed for
> stm32 when TF_A_EXTRA_ARGS is used, like it is done currently in
> DistroKit, so a global dependency might be to broad. However dtc is
> probably needed for arm targets anyway, so it should not hurt that
> much?!

It's needed for few other platforms that use device tree as well,
but most don't use it.
I also that think enabling it unconditionally is ok.

I'll include your change in my v5 for the upstream tf-a rule,
Thanks!

> Signed-off-by: Alexander Dahl <post@lespocky.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  rules/tf-a.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rules/tf-a.in b/rules/tf-a.in
> index 3cddf79..ba04f44 100644
> --- a/rules/tf-a.in
> +++ b/rules/tf-a.in
> @@ -2,6 +2,7 @@
>  
>  menuconfig TF_A
>  	select BOOTLOADER
> +	select HOST_DTC
>  	prompt "ARM Trusted Firmware-A        "
>  	depends on ARCH_ARM || ARCH_ARM64
>  	bool
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de

Re: [DistroKit] [PATCH] tf-a: Add missing dependency to host dtc

[Michael Olbrich]

On Thu, Mar 19, 2020 at 05:28:47PM +0100, Ahmad Fatoum wrote:
> On 3/14/20 2:05 PM, Alexander Dahl wrote:
> > Build after clean all failed like this:
> > 
> >     /bin/sh: 1: dtc: not found
> >     dtc version too old (), you need at least version 1.4.4
> > 
> > A quick inspection of the tf-a source showed dtc is only needed for
> > stm32 when TF_A_EXTRA_ARGS is used, like it is done currently in
> > DistroKit, so a global dependency might be to broad. However dtc is
> > probably needed for arm targets anyway, so it should not hurt that
> > much?!
> 
> It's needed for few other platforms that use device tree as well,
> but most don't use it.
> I also that think enabling it unconditionally is ok.

What about an option? Similar to the BAREBOX_NEEDS_* options.

Michael

> I'll include your change in my v5 for the upstream tf-a rule,
> Thanks!
> 
> > Signed-off-by: Alexander Dahl <post@lespocky.de>
> 
> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> 
> > ---
> >  rules/tf-a.in | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/rules/tf-a.in b/rules/tf-a.in
> > index 3cddf79..ba04f44 100644
> > --- a/rules/tf-a.in
> > +++ b/rules/tf-a.in
> > @@ -2,6 +2,7 @@
> >  
> >  menuconfig TF_A
> >  	select BOOTLOADER
> > +	select HOST_DTC
> >  	prompt "ARM Trusted Firmware-A        "
> >  	depends on ARCH_ARM || ARCH_ARM64
> >  	bool
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> DistroKit mailing list
> DistroKit@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de