Re: [DistroKit] [PATCH v1 2/1] scripts: p-all: add mips platform

[Robert Schwebel <r.schwebel@pengutronix.de>]

On Mon, Mar 02, 2020 at 10:37:38AM +0100, Roland Hieber wrote:
> On Mon, Mar 02, 2020 at 09:04:21AM +0100, Uwe Kleine-König wrote:
> > On Fri, Feb 28, 2020 at 10:24:52AM +0100, Roland Hieber wrote:
> > > This way it is less likely to get lost when doing a PTXdist migrate for
> > > all platforms.  
> > > ---
> > >  scripts/p-all | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/scripts/p-all b/scripts/p-all
> > > index bdef601ad99c..7eb9694e6e6e 100755
> > > --- a/scripts/p-all
> > > +++ b/scripts/p-all
> > > @@ -7,7 +7,7 @@ else
> > >  	echo Note: using PTXDIST=$PTXDIST
> > >  	tput sgr 0   # back to normal
> > >  fi
> > > -PLATFORMS="v7a v8a rpi"
> > > +PLATFORMS="v7a v8a rpi mips"
> > 
> > What about making this instead:
> > 
> > diff --git a/scripts/p-all b/scripts/p-all
> > index bdef601ad99c..bb95ed265e19 100755
> > --- a/scripts/p-all
> > +++ b/scripts/p-all
> > @@ -7,7 +7,7 @@ else
> >         echo Note: using PTXDIST=$PTXDIST
> >         tput sgr 0   # back to normal
> >  fi
> > -PLATFORMS="v7a v8a rpi"
> > -for p in $PLATFORMS; do
> > -       $PTXDIST --platformconfig=configs/platform-${p}/platformconfig "$@"
> > +
> > +for pcfg in configs/platform-*/platformconfig; do
> > +       $PTXDIST --platformconfig="$pcfg" "$@"
> >  done
> 
> LGTM.

Uwe, could you resend with a proper patch & S-o-b?

rsc
-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de