Re: [DistroKit] [PATCH] v7a: image-vexpress: remove unneeded partition

[Robert Schwebel <r.schwebel@pengutronix.de>]

On Mon, Feb 11, 2019 at 02:29:32PM +0100, Roland Hieber wrote:
> The additional partition at the end results in an hdimage of ~1 GB in
> size; compared to the ~60 MB of the other hdimages created by
> platform-v7a, this seems out of proportion as the image will consist
> mainly of zeroes. It is not clear to me why this partition was added at
> all in commit cc1fee168d ("platform-v7a: vexpress: add board support"),
> but it turns out that qemu-vexpress boots fine without it.
> 
> Reported-by: Alexander Dahl <post@lespocky.de>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  configs/platform-v7a/config/images/vexpress.config | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/configs/platform-v7a/config/images/vexpress.config b/configs/platform-v7a/config/images/vexpress.config
> index 7cfaaaa..8ca2f9c 100644
> --- a/configs/platform-v7a/config/images/vexpress.config
> +++ b/configs/platform-v7a/config/images/vexpress.config
> @@ -12,13 +12,6 @@ image @IMAGE@ {
>  		partition-type = 0x83
>  		size = 512M
>  	}
> -	/* expand image size to 64 MiB; dummy size, results in 0 bytes length */
> -	partition end {
> -		image = /dev/null
> -		size = 1M
> -		offset = 1025M
> -		in-partition-table = false
> -	}
>  }
>  
>  /* vim: set tabstop=8 noexpandtab : */
> -- 
> 2.20.1

Applied to next.

rsc
-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de