DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: distrokit@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>,
	Alexander Dahl <post@lespocky.de>,
	Roland Hieber <rhi@pengutronix.de>,
	Rouven Czerwinski <rcz@pengutronix.de>
Subject: [DistroKit] [PATCH] v7a: image-vexpress: remove unneeded partition
Date: Mon, 11 Feb 2019 14:29:32 +0100	[thread overview]
Message-ID: <20190211132932.19862-1-rhi@pengutronix.de> (raw)

The additional partition at the end results in an hdimage of ~1 GB in
size; compared to the ~60 MB of the other hdimages created by
platform-v7a, this seems out of proportion as the image will consist
mainly of zeroes. It is not clear to me why this partition was added at
all in commit cc1fee168d ("platform-v7a: vexpress: add board support"),
but it turns out that qemu-vexpress boots fine without it.

Reported-by: Alexander Dahl <post@lespocky.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 configs/platform-v7a/config/images/vexpress.config | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/configs/platform-v7a/config/images/vexpress.config b/configs/platform-v7a/config/images/vexpress.config
index 7cfaaaa..8ca2f9c 100644
--- a/configs/platform-v7a/config/images/vexpress.config
+++ b/configs/platform-v7a/config/images/vexpress.config
@@ -12,13 +12,6 @@ image @IMAGE@ {
 		partition-type = 0x83
 		size = 512M
 	}
-	/* expand image size to 64 MiB; dummy size, results in 0 bytes length */
-	partition end {
-		image = /dev/null
-		size = 1M
-		offset = 1025M
-		in-partition-table = false
-	}
 }
 
 /* vim: set tabstop=8 noexpandtab : */
-- 
2.20.1


_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de

             reply	other threads:[~2019-02-11 13:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 13:29 Roland Hieber [this message]
2019-02-11 13:33 ` Robert Schwebel
2019-02-11 14:46   ` Michael Olbrich
2019-02-11 15:06     ` Robert Schwebel
2019-02-11 16:18   ` [DistroKit] [PATCH v2] v7a: image-vexpress: fix comment in image config Roland Hieber
2019-02-12  6:30     ` Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211132932.19862-1-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    --cc=m.olbrich@pengutronix.de \
    --cc=post@lespocky.de \
    --cc=rcz@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox