* [DistroKit] [PATCH 0/2] Little housekeeping
@ 2018-10-18 10:38 Alexander Dahl
2018-10-18 10:38 ` [DistroKit] [PATCH 1/2] platform: v7a: Loosen toolchain version to minor release Alexander Dahl
2018-10-18 10:38 ` [DistroKit] [PATCH 2/2] platform: v7a: Remove no longer needed make rule Alexander Dahl
0 siblings, 2 replies; 5+ messages in thread
From: Alexander Dahl @ 2018-10-18 10:38 UTC (permalink / raw)
To: distrokit
Hei hei,
while looking at genimage example configs I noticed a now useless make
rule in the v7a platform. The other patch is lying around here a
little longer, but I just post it anyway, if someone needs it.
Alexander Dahl (2):
platform: v7a: Loosen toolchain version to minor release
platform: v7a: Remove no longer needed make rule
configs/platform-v7a/platformconfig | 2 +-
configs/platform-v7a/rules/image-boot-vfat.make | 49 -------------------------
2 files changed, 1 insertion(+), 50 deletions(-)
delete mode 100644 configs/platform-v7a/rules/image-boot-vfat.make
--
2.11.0
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* [DistroKit] [PATCH 1/2] platform: v7a: Loosen toolchain version to minor release
2018-10-18 10:38 [DistroKit] [PATCH 0/2] Little housekeeping Alexander Dahl
@ 2018-10-18 10:38 ` Alexander Dahl
2018-10-23 6:57 ` Robert Schwebel
2018-10-18 10:38 ` [DistroKit] [PATCH 2/2] platform: v7a: Remove no longer needed make rule Alexander Dahl
1 sibling, 1 reply; 5+ messages in thread
From: Alexander Dahl @ 2018-10-18 10:38 UTC (permalink / raw)
To: distrokit; +Cc: Alexander Dahl
From: Alexander Dahl <post@lespocky.de>
No need to insist on point release. This way a user can update the
toolchain to (the not yet existent) 2018.02.x once it arrives, without
the need to touch the BSP. This makes it consistent with the other
platforms rpi and v8a.
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
configs/platform-v7a/platformconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/platform-v7a/platformconfig b/configs/platform-v7a/platformconfig
index 27fe3bb..81e7bd4 100644
--- a/configs/platform-v7a/platformconfig
+++ b/configs/platform-v7a/platformconfig
@@ -63,7 +63,7 @@ PTXCONF_SYSROOT_CROSS="${PTXDIST_PLATFORMDIR}/sysroot-cross"
#
# toolchain
#
-PTXCONF_CROSSCHAIN_VENDOR="OSELAS.Toolchain-2018.02.0"
+PTXCONF_CROSSCHAIN_VENDOR="OSELAS.Toolchain-2018.02"
PTXCONF_CROSSCHAIN_CHECK="7.3.1"
PTXCONF_LIBC_GLIBC=y
# PTXCONF_LIBC_UCLIBC is not set
--
2.11.0
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [DistroKit] [PATCH 1/2] platform: v7a: Loosen toolchain version to minor release
2018-10-18 10:38 ` [DistroKit] [PATCH 1/2] platform: v7a: Loosen toolchain version to minor release Alexander Dahl
@ 2018-10-23 6:57 ` Robert Schwebel
0 siblings, 0 replies; 5+ messages in thread
From: Robert Schwebel @ 2018-10-23 6:57 UTC (permalink / raw)
To: Alexander Dahl; +Cc: distrokit, Alexander Dahl
On Thu, Oct 18, 2018 at 12:38:37PM +0200, Alexander Dahl wrote:
> From: Alexander Dahl <post@lespocky.de>
>
> No need to insist on point release. This way a user can update the
> toolchain to (the not yet existent) 2018.02.x once it arrives, without
> the need to touch the BSP. This makes it consistent with the other
> platforms rpi and v8a.
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
> configs/platform-v7a/platformconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
rsc
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* [DistroKit] [PATCH 2/2] platform: v7a: Remove no longer needed make rule
2018-10-18 10:38 [DistroKit] [PATCH 0/2] Little housekeeping Alexander Dahl
2018-10-18 10:38 ` [DistroKit] [PATCH 1/2] platform: v7a: Loosen toolchain version to minor release Alexander Dahl
@ 2018-10-18 10:38 ` Alexander Dahl
2018-10-23 6:57 ` Robert Schwebel
1 sibling, 1 reply; 5+ messages in thread
From: Alexander Dahl @ 2018-10-18 10:38 UTC (permalink / raw)
To: distrokit
That one was used before renaming the platform to v7a, and later
reintroducing support for Raspberry Pi 2. The package is not activated
anymore and so there's no need to overwrite the rule from ptxdist
itself anymore.
Signed-off-by: Alexander Dahl <ada@thorsis.com>
---
configs/platform-v7a/rules/image-boot-vfat.make | 49 -------------------------
1 file changed, 49 deletions(-)
delete mode 100644 configs/platform-v7a/rules/image-boot-vfat.make
diff --git a/configs/platform-v7a/rules/image-boot-vfat.make b/configs/platform-v7a/rules/image-boot-vfat.make
deleted file mode 100644
index 185c2b7..0000000
--- a/configs/platform-v7a/rules/image-boot-vfat.make
+++ /dev/null
@@ -1,49 +0,0 @@
-# -*-makefile-*-
-#
-# Copyright (C) 2012 by Michael Olbrich <m.olbrich@pengutronix.de>
-#
-# See CREDITS for details about who has contributed to this project.
-#
-# For further information about the PTXdist project and license conditions
-# see the README file.
-#
-
-#
-# We provide this package
-#
-IMAGE_PACKAGES-$(PTXCONF_IMAGE_BOOT_VFAT) += image-boot-vfat
-
-#
-# Paths and names
-#
-IMAGE_BOOT_VFAT := image-boot-vfat
-IMAGE_BOOT_VFAT_DIR := $(BUILDDIR)/$(IMAGE_BOOT_VFAT)
-IMAGE_BOOT_VFAT_IMAGE := $(IMAGEDIR)/boot.vfat
-IMAGE_BOOT_VFAT_DATA := \
- $(wildcard $(PTXDIST_PLATFORMCONFIGDIR)/rpi-firmware/*.bin) \
- $(wildcard $(PTXDIST_PLATFORMCONFIGDIR)/rpi-firmware/*.elf) \
- $(wildcard $(PTXDIST_PLATFORMCONFIGDIR)/rpi-firmware/*.dat) \
- $(wildcard $(PTXDIST_PLATFORMCONFIGDIR)/rpi-firmware/config.txt)
-IMAGE_BOOT_VFAT_CONFIG := boot-vfat.config
-
-# ----------------------------------------------------------------------------
-# Image
-# ----------------------------------------------------------------------------
-
-define squote_and_comma
-$(subst $(ptx/def/space),$(comma) ,$(addsuffix $(ptx/def/squote),$(addprefix $(ptx/def/squote),$(1))))
-endef
-
-
-IMAGE_BOOT_VFAT_ENV := \
- FIRMWARE_RPI2="$(call squote_and_comma,$(IMAGE_BOOT_VFAT_DATA))"
-
-$(IMAGE_BOOT_VFAT_IMAGE):
- @$(call targetinfo)
- @GPU_MEM=$(PTXCONF_IMAGE_BOOT_VFAT_GPU_MEM) \
- ptxd_replace_magic "$(PTXDIST_PLATFORMCONFIGDIR)/rpi-firmware/config.txt" > \
- "$(PTXDIST_TEMPDIR)/config.txt"
- @$(call image/genimage, IMAGE_BOOT_VFAT)
- @$(call finish)
-
-# vim: syntax=make
--
2.11.0
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [DistroKit] [PATCH 2/2] platform: v7a: Remove no longer needed make rule
2018-10-18 10:38 ` [DistroKit] [PATCH 2/2] platform: v7a: Remove no longer needed make rule Alexander Dahl
@ 2018-10-23 6:57 ` Robert Schwebel
0 siblings, 0 replies; 5+ messages in thread
From: Robert Schwebel @ 2018-10-23 6:57 UTC (permalink / raw)
To: Alexander Dahl; +Cc: distrokit
On Thu, Oct 18, 2018 at 12:38:38PM +0200, Alexander Dahl wrote:
> That one was used before renaming the platform to v7a, and later
> reintroducing support for Raspberry Pi 2. The package is not activated
> anymore and so there's no need to overwrite the rule from ptxdist
> itself anymore.
>
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> ---
> configs/platform-v7a/rules/image-boot-vfat.make | 49 -------------------------
> 1 file changed, 49 deletions(-)
> delete mode 100644 configs/platform-v7a/rules/image-boot-vfat.make
Applied, thanks.
rsc
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-23 6:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-18 10:38 [DistroKit] [PATCH 0/2] Little housekeeping Alexander Dahl
2018-10-18 10:38 ` [DistroKit] [PATCH 1/2] platform: v7a: Loosen toolchain version to minor release Alexander Dahl
2018-10-23 6:57 ` Robert Schwebel
2018-10-18 10:38 ` [DistroKit] [PATCH 2/2] platform: v7a: Remove no longer needed make rule Alexander Dahl
2018-10-23 6:57 ` Robert Schwebel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox