Re: [DistroKit] [PATCH v2] v7a: kernel: Enable I/O expander driver for STM32MP135F-DK

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Uwe,

On 01.08.24 00:35, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Thanks for your patch.

> 
> The i2c I/O expander MCP23S08 provides GPIOs to reset various components
> (ethernet phy, display bridge, camera). The I/O expander is configured
> as built-in as it is needed for nfs-root operation (once the kernel
> contains the needed adaptions for the stmmac to support the stm32mp13x).
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Just a small nit below:

> +CONFIG_PINCTRL_MCP23S08_I2C=y
> +CONFIG_PINCTRL_MCP23S08_SPI=y

Nit: We don't seem to actually need the SPI driver.

Cheers,
Ahmad

> +CONFIG_PINCTRL_MCP23S08=y
>  # CONFIG_PINCTRL_MICROCHIP_SGPIO is not set
>  # CONFIG_PINCTRL_OCELOT is not set
>  # CONFIG_PINCTRL_PALMAS is not set
> 
> base-commit: 747926d7f2936451c93f72b8dc0cfc58c7bb3122

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |