Re: [DistroKit] [PATCH v1 2/5] v8a: images: imx8m: add barebox state partition

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 11.01.24 18:07, Jan Lübbe wrote:
> On Thu, 2024-01-11 at 16:01 +0100, Leonard Göhrs wrote:
>> Having a place to store state allows us to use RAUC on i.MX8M based boards.
>>
>> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
>> ---
>>  configs/platform-v8a/config/images/imx8m.config | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/configs/platform-v8a/config/images/imx8m.config b/configs/platform-v8a/config/images/imx8m.config
>> index 59cdac1..fcb3c07 100644
>> --- a/configs/platform-v8a/config/images/imx8m.config
>> +++ b/configs/platform-v8a/config/images/imx8m.config
>> @@ -9,8 +9,13 @@ image @IMAGE@ {
>>                 in-partition-table = false
>>                 holes = {"(440; 32K)"}

If you are changing the partitioning, please increase the barebox
partition size too. As we are adding more boards to the same binary,
this area will get more crowded and we are already nearly at the
limit.

>>         }
>> -       partition root-A {
>> +       partition barebox-state {
>>                 offset = 2M
>> +               size = 1M
> 
> There's no need to use 1MB for the state partition, a few sectors should be
> enough (i.e. 32KB).
> 
>> +               partition-type-uuid = 4778ed65-bf42-45fa-9c5b-287a1dc4aab1 # barebox-state
>> +               image = /dev/null
>> +       }
>> +       partition root-A {
> 
> Keep the root-A partition @ 2M and add a small state partition before the
> rootfs.
> 
>>                 image = "root.ext2"
>>                 partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
>>         }
> 
> Similar to the rock3a.config, we should have a barebox env partition as well.

@Michael, as we are touching partitioning, should we increase the partition
size in the same go? What size would you suggest?

Cheers,
Ahmad

> 
> Jan

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |