From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 25 Jan 2024 09:48:33 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rSvPU-001Bm7-0u for lore@lore.pengutronix.de; Thu, 25 Jan 2024 09:48:33 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rSvPU-0006Yc-ER; Thu, 25 Jan 2024 09:48:32 +0100 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rSvPR-0006Y7-Ic; Thu, 25 Jan 2024 09:48:29 +0100 Message-ID: Date: Thu, 25 Jan 2024 09:48:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: distrokit@pengutronix.de, Marc Kleine-Budde , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Lucas Stach References: <20240117135625.2863370-1-m.olbrich@pengutronix.de> From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [DistroKit] [PATCH] platform-v8a: kernelconfig: cleanup X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Jan_L=C3=BCbbe?= Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello Michael, On 22.01.24 16:57, Michael Olbrich wrote: > On Mon, Jan 22, 2024 at 04:01:36PM +0100, Ahmad Fatoum wrote: >> On 17.01.24 14:56, Michael Olbrich wrote: >>> -CONFIG_BLK_DEV_INITRD=y >>> -CONFIG_INITRAMFS_SOURCE="" >>> -# CONFIG_RD_GZIP is not set >>> -# CONFIG_RD_BZIP2 is not set >>> -# CONFIG_RD_LZMA is not set >>> -# CONFIG_RD_XZ is not set >>> -# CONFIG_RD_LZO is not set >>> -# CONFIG_RD_LZ4 is not set >>> -CONFIG_RD_ZSTD=y >>> +# CONFIG_BLK_DEV_INITRD is not set >> >> We want to keep CONFIG_BLK_DEV_INITRD, so DistroKit systems can easily >> boot common distros like Debian that ship with an initramfs. > > I was not aware that this is a use-case for DistroKit. I'm not sure how > that is supposed to work but fine. It was suggested by Jan IIRC. Maybe he can chime in. >>> -CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y >>> +# CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE is not set >>> # CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE is not set >>> # CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE is not set >>> # CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND is not set >>> # CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE is not set >>> -# CONFIG_CPU_FREQ_DEFAULT_GOV_SCHEDUTIL is not set >>> +CONFIG_CPU_FREQ_DEFAULT_GOV_SCHEDUTIL=y >> >> Why? The default can be changed later on, but using >> performance as default allows for faster boot. > > It does? By how much? > > DistroKit does not change the default later so it runs with the maximum > frequency the whole time. That is not a sane default for me. That's a good point. As long as we don't change it later on, we shouldn't be setting it. >>> -# CONFIG_CMA_DEBUGFS is not set >>> +CONFIG_CMA_DEBUGFS=y >> >> I never used this. What do we need this for given that we don't enable >> graphic support? > > CMA is not only used by graphics drivers. It's nice to have just in case, > just like the other debug options we've enabled. Ok. >> The Espressobin has an on-board Ethernet switch, but it seems it was >> not enabled before? > > I'm not sure what makes sense for the Espressobin, that's why I asked Uwe > to look at that. > But I mostly disabled this stuff, because it's not actually configured > anywhere in DistroKit. Ok. Cheers, Ahmad > >>> -CONFIG_PCIE_ROCKCHIP=y >>> -CONFIG_PCIE_ROCKCHIP_HOST=y >>> -CONFIG_PCIE_ROCKCHIP_EP=y >>> -CONFIG_PCI_XGENE=y >>> -CONFIG_PCI_XGENE_MSI=y >>> +# CONFIG_PCIE_ROCKCHIP_HOST is not set >>> +# CONFIG_PCI_XGENE is not set >> >> In case someone is wondering too: These are rk3399-specific. rk3568 PCI remains enabled. > > Right. There were several drivers enabled that were not used by any of the > boards supported by DistroKit. > >> The rest looks ok. > > Regards, > Michael > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |