From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: References: <20200302110356.19112-1-a.fatoum@pengutronix.de> <20200302110356.19112-3-a.fatoum@pengutronix.de> <20200303094328.t4hrgr5rgafm5jcc@pengutronix.de> From: Ahmad Fatoum Message-ID: Date: Tue, 3 Mar 2020 10:54:43 +0100 MIME-Version: 1.0 In-Reply-To: <20200303094328.t4hrgr5rgafm5jcc@pengutronix.de> Content-Language: en-US Subject: Re: [DistroKit] [PATCH 2/6] v7a: barebox: add new stm32mp rule List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: distrokit-bounces@pengutronix.de Sender: "DistroKit" To: Roland Hieber Cc: distrokit@pengutronix.de Hi, On 3/3/20 10:43 AM, Roland Hieber wrote: > On Mon, Mar 02, 2020 at 12:03:52PM +0100, Ahmad Fatoum wrote: >> Since v2019.12.0, barebox now has SD/MMC and Ethernet support for the >> STM32MP1. Thus there is nothing holding us back from extending >> DistroKit's v7a platform to support the SoC. Add a barebox-stm32mp >> rule as first step. >> >> The barebox rule add here is only meant as second-stage bootloader >> (SSBL). First-stage (FSBL) will be TF-A introduced in a later patch. >> >> Signed-off-by: Ahmad Fatoum >> --- >> +CONFIG_NET_NETCONSOLE=y > > Is this needed? It's enabled in most other DistroKit barebox configs as well. I've never used it myself, but we don't exactly have a size limitation, so I don't think it hurts. >> +++ b/configs/platform-v7a/rules/barebox-stm32mp.make >> @@ -0,0 +1,107 @@ >> +# -*-makefile-*- >> +# >> +# Copyright (C) 2017 by Sascha Hauer > > Very humble of you to give credit to someone else :) I trust Sascha's judgement on how to deal with infringements on my modifications to his base rule. ;-) Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ DistroKit mailing list DistroKit@pengutronix.de