From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 22 Apr 2025 11:26:20 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u79tU-003zfm-1e for lore@lore.pengutronix.de; Tue, 22 Apr 2025 11:26:20 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1u79tU-0005eB-1U; Tue, 22 Apr 2025 11:26:20 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPv6:::1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1u79tS-0005dM-8v; Tue, 22 Apr 2025 11:26:18 +0200 Message-ID: From: Fabian Pflug To: Ahmad Fatoum , distrokit@pengutronix.de Date: Tue, 22 Apr 2025 11:26:18 +0200 In-Reply-To: <8150c53a-dd52-4abb-a678-d406f170cf75@pengutronix.de> References: <20250422085421.1266359-1-f.pflug@pengutronix.de> <20250422085421.1266359-2-f.pflug@pengutronix.de> <8150c53a-dd52-4abb-a678-d406f170cf75@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 Subject: Re: [DistroKit] [PATCH 1/1] v8a: Add support for tq-ma93xxca X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello Ahmad, > Nitpick: chosen, random Fixed >=20 > > +CONFIG_HAB=3Dy > > +CONFIG_AHAB=3Dy >=20 > I think we should leave this disabled, until we start actually doing > verified boot in DistroKit. CONFIG_IMX93 sets CONFIG_AHAB, which in turn sets CONFIG_HAB Not really possible to disable. >=20 > > +CONFIG_USB_EHCI=3Dy >=20 > Interesting. I thought the i.MX93 would use a USB 3.0 capable > controller > like the i.MX8MP, but apparently it's not so. Nope, USB2.0 only >=20 > > diff --git a/configs/platform-v8a/config/images/imx93.config > > b/configs/platform-v8a/config/images/imx93.config > > new file mode 100644 > > index 0000000..bbdb232 > > --- /dev/null > > +++ b/configs/platform-v8a/config/images/imx93.config > > @@ -0,0 +1,21 @@ > > +image @IMAGE@ { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0hdimage { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0align =3D 1M > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0partition-table-type =3D gpt > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0partition barebox { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0image =3D "@BAREBOX_IMAGE@" > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0offset =3D 32k > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0in-partition-table =3D false >=20 > Why not make it a proper GPT partition? I know we are not consistent > with that in existing boards, but for new board support, we should > put > everything into a GPT partition from the get-go. I have no opinion about it. It was just copy & paste from all the other boards. Will do what the majority agrees upon. >=20 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0partition barebox-state { >=20 > Please add a barebox-environment partition as well with a comment > that > it's currently unused as the environment comes from the SPI flash. >=20 > That way, we'll be able to just switch over to using environment on > the > boot medium in future without changing the partition layout again. >=20 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0offset =3D 3M > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0size =3D 1M > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0partition-type-uuid =3D barebox-state > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0partition root-A { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0offset =3D 4M >=20 > If everything has a size and is described in the partition table, do > we still need the offset (except of course for the barebox > partition). >=20 > > +Boot Media > > +---------- > > + > > +Booting is available via multiple sources (Compare Table 6: Boot > > configuration i.MX 93 from . >=20 > from? missing rest of line? Good catch. Yeah missing. >=20 >=20 > > +Write the bootloader ``platform-v8a/images/barebox-tqma93xx.img`` > > to USB: >=20 > s/Write to/Upload via/ >=20 > Maybe even add the full command: >=20 > =C2=A0 imx-usb-loader platform-v8a/images/barebox-tqma93xx.img See next line on the RST: >=20 > > + > > +.. code-block:: shell > > + > > +=C2=A0=C2=A0=C2=A0 platform-v8a/sysroot-host/bin/imx-usb-loader platfo= rm- > > v8a/images/barebox-tqma93xx.img > > + > > +In Barebox, set the default boot location to nfs: > > + > > +=C2=A0=C2=A0=C2=A0 nv boot.default: > > nfs://dude06//ptx/work/user/fpg/DistroKit/platform-v8a/root >=20 > Drop the colon, so it's an executable command. Done >=20 > Thanks for including docs. You're welcome :) Will send a new patch later, with your and other remarks. Fabian >=20 > Cheers, > Ahmad >=20