From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 22 Jan 2024 16:01:43 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rRvny-00BcVV-1C for lore@lore.pengutronix.de; Mon, 22 Jan 2024 16:01:43 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rRvnz-0005vU-46; Mon, 22 Jan 2024 16:01:43 +0100 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rRvnt-0005uG-57; Mon, 22 Jan 2024 16:01:37 +0100 Message-ID: Date: Mon, 22 Jan 2024 16:01:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Michael Olbrich , distrokit@pengutronix.de References: <20240117135625.2863370-1-m.olbrich@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20240117135625.2863370-1-m.olbrich@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [DistroKit] [PATCH] platform-v8a: kernelconfig: cleanup X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Marc Kleine-Budde , Lucas Stach Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello, On 17.01.24 14:56, Michael Olbrich wrote: > -CONFIG_BLK_DEV_INITRD=y > -CONFIG_INITRAMFS_SOURCE="" > -# CONFIG_RD_GZIP is not set > -# CONFIG_RD_BZIP2 is not set > -# CONFIG_RD_LZMA is not set > -# CONFIG_RD_XZ is not set > -# CONFIG_RD_LZO is not set > -# CONFIG_RD_LZ4 is not set > -CONFIG_RD_ZSTD=y > +# CONFIG_BLK_DEV_INITRD is not set We want to keep CONFIG_BLK_DEV_INITRD, so DistroKit systems can easily boot common distros like Debian that ship with an initramfs. > -CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y > +# CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE is not set > # CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE is not set > # CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE is not set > # CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND is not set > # CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE is not set > -# CONFIG_CPU_FREQ_DEFAULT_GOV_SCHEDUTIL is not set > +CONFIG_CPU_FREQ_DEFAULT_GOV_SCHEDUTIL=y Why? The default can be changed later on, but using performance as default allows for faster boot. > CONFIG_CMA=y > # CONFIG_CMA_DEBUG is not set > -# CONFIG_CMA_DEBUGFS is not set > +CONFIG_CMA_DEBUGFS=y I never used this. What do we need this for given that we don't enable graphic support? > -CONFIG_NET_DSA=m > -# CONFIG_NET_DSA_TAG_NONE is not set > -# CONFIG_NET_DSA_TAG_AR9331 is not set > -# CONFIG_NET_DSA_TAG_BRCM is not set > -# CONFIG_NET_DSA_TAG_BRCM_LEGACY is not set > -# CONFIG_NET_DSA_TAG_BRCM_PREPEND is not set > -# CONFIG_NET_DSA_TAG_HELLCREEK is not set > -# CONFIG_NET_DSA_TAG_GSWIP is not set > -# CONFIG_NET_DSA_TAG_DSA is not set > -# CONFIG_NET_DSA_TAG_EDSA is not set > -# CONFIG_NET_DSA_TAG_MTK is not set > -# CONFIG_NET_DSA_TAG_KSZ is not set > -CONFIG_NET_DSA_TAG_OCELOT=m > -CONFIG_NET_DSA_TAG_OCELOT_8021Q=m > -# CONFIG_NET_DSA_TAG_QCA is not set > -# CONFIG_NET_DSA_TAG_RTL4_A is not set > -# CONFIG_NET_DSA_TAG_RTL8_4 is not set > -# CONFIG_NET_DSA_TAG_RZN1_A5PSW is not set > -# CONFIG_NET_DSA_TAG_LAN9303 is not set > -# CONFIG_NET_DSA_TAG_SJA1105 is not set > -# CONFIG_NET_DSA_TAG_TRAILER is not set > -# CONFIG_NET_DSA_TAG_XRS700X is not set > -CONFIG_VLAN_8021Q=m > -CONFIG_VLAN_8021Q_GVRP=y > -CONFIG_VLAN_8021Q_MVRP=y > -CONFIG_LLC=m > +# CONFIG_BRIDGE is not set > +# CONFIG_NET_DSA is not set The Espressobin has an on-board Ethernet switch, but it seems it was not enabled before? > -CONFIG_PCIE_ROCKCHIP=y > -CONFIG_PCIE_ROCKCHIP_HOST=y > -CONFIG_PCIE_ROCKCHIP_EP=y > -CONFIG_PCI_XGENE=y > -CONFIG_PCI_XGENE_MSI=y > +# CONFIG_PCIE_ROCKCHIP_HOST is not set > +# CONFIG_PCI_XGENE is not set In case someone is wondering too: These are rk3399-specific. rk3568 PCI remains enabled. The rest looks ok. Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |