From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 21 Aug 2024 12:07:06 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sgiF8-00Bsld-12 for lore@lore.pengutronix.de; Wed, 21 Aug 2024 12:07:06 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sgiF7-00029Z-2d; Wed, 21 Aug 2024 12:07:05 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sgiF3-00029K-43; Wed, 21 Aug 2024 12:07:01 +0200 Message-ID: Date: Wed, 21 Aug 2024 12:07:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Oleksij Rempel , distrokit@pengutronix.de References: <20240821095133.1471779-1-o.rempel@pengutronix.de> <20240821095133.1471779-6-o.rempel@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: <20240821095133.1471779-6-o.rempel@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [DistroKit] [PATCH v1 5/9] mips/mipsel: barebox: use CONSOLE_ACTIVATE_NONE X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello Oleksij, On 21.08.24 11:51, Oleksij Rempel wrote: > For system booting with device tree, the default console should be > specifie via /chosen/stdout-path and barebox should not unconditionally > enable any consoles. This avoids issues with probe order > (CONFIG_CONSOLE_ACTIVATE_FIRST) and crosstalk with serial devices that > don't expect console output (CONFIG_CONSOLE_ACTIVATE_ALL). Did you test this? arch/mips/dts/qemu-malta.dts doesn't have a chosen /chosen/stdout-path, so this change would most likely render the console completely silent. In general, we will want to use the new CONFIG_CONSOLE_ACTIVATE_ALL_FALLBACK option[1]. It would enable all consoles as a fallback if none was activated explicitly. It hasn't hit a barebox release yet though. For Malta, barebox should probably get a /chosen/stdout-path if there's indeed no board code or environment activating any consoles. [1]: https://lore.barebox.org/barebox/20240730083451.2203330-1-a.fatoum@pengutronix.de/ Cheers, Ahmad > > Signed-off-by: Oleksij Rempel > --- > configs/platform-mips/barebox-ar9331.config | 4 ++-- > configs/platform-mips/barebox-ar9331.config.diff | 2 +- > configs/platform-mips/barebox-malta.config | 4 ++-- > configs/platform-mips/barebox-malta.config.diff | 2 +- > configs/platform-mips/barebox.config | 4 ++-- > configs/platform-mipsel/barebox-malta.config.diff | 4 +--- > configs/platform-mipsel/barebox.config | 4 ++-- > 7 files changed, 11 insertions(+), 13 deletions(-) > > diff --git a/configs/platform-mips/barebox-ar9331.config b/configs/platform-mips/barebox-ar9331.config > index 2e72041e..4e888630 100644 > --- a/configs/platform-mips/barebox-ar9331.config > +++ b/configs/platform-mips/barebox-ar9331.config > @@ -140,9 +140,9 @@ CONFIG_IMD=y > CONFIG_CONSOLE_FULL=y > # CONFIG_CONSOLE_SIMPLE is not set > # CONFIG_CONSOLE_NONE is not set > -CONFIG_CONSOLE_ACTIVATE_FIRST=y > +# CONFIG_CONSOLE_ACTIVATE_FIRST is not set > # CONFIG_CONSOLE_ACTIVATE_ALL is not set > -# CONFIG_CONSOLE_ACTIVATE_NONE is not set > +CONFIG_CONSOLE_ACTIVATE_NONE=y > # CONFIG_CONSOLE_ALLOW_COLOR is not set > # CONFIG_PBL_CONSOLE is not set > # CONFIG_CONSOLE_RATP is not set > diff --git a/configs/platform-mips/barebox-ar9331.config.diff b/configs/platform-mips/barebox-ar9331.config.diff > index 524a3ccb..ef219ed5 100644 > --- a/configs/platform-mips/barebox-ar9331.config.diff > +++ b/configs/platform-mips/barebox-ar9331.config.diff > @@ -1,4 +1,4 @@ > -969c2d8bca570a40257c2a71b4e37c8d > +56c8bdde9f772e6da0ade7950dae7293 > # CONFIG_BOARD_8DEVICES_LIMA is not set > # CONFIG_BOARD_TPLINK_WDR4300 is not set > # CONFIG_SOC_QCA_AR9344 is undefined > diff --git a/configs/platform-mips/barebox-malta.config b/configs/platform-mips/barebox-malta.config > index 094b8dc3..4ce1c407 100644 > --- a/configs/platform-mips/barebox-malta.config > +++ b/configs/platform-mips/barebox-malta.config > @@ -143,9 +143,9 @@ CONFIG_IMD=y > CONFIG_CONSOLE_FULL=y > # CONFIG_CONSOLE_SIMPLE is not set > # CONFIG_CONSOLE_NONE is not set > -CONFIG_CONSOLE_ACTIVATE_FIRST=y > +# CONFIG_CONSOLE_ACTIVATE_FIRST is not set > # CONFIG_CONSOLE_ACTIVATE_ALL is not set > -# CONFIG_CONSOLE_ACTIVATE_NONE is not set > +CONFIG_CONSOLE_ACTIVATE_NONE=y > CONFIG_CONSOLE_ALLOW_COLOR=y > # CONFIG_PBL_CONSOLE is not set > # CONFIG_CONSOLE_RATP is not set > diff --git a/configs/platform-mips/barebox-malta.config.diff b/configs/platform-mips/barebox-malta.config.diff > index 6e5ee679..687dbaf0 100644 > --- a/configs/platform-mips/barebox-malta.config.diff > +++ b/configs/platform-mips/barebox-malta.config.diff > @@ -1,4 +1,4 @@ > -969c2d8bca570a40257c2a71b4e37c8d > +56c8bdde9f772e6da0ade7950dae7293 > # CONFIG_AT803X_PHY is not set > CONFIG_BAREBOX_MAX_IMAGE_SIZE=0x400000 > CONFIG_BAUDRATE=38400 > diff --git a/configs/platform-mips/barebox.config b/configs/platform-mips/barebox.config > index 689e6bc8..d16a97f3 100644 > --- a/configs/platform-mips/barebox.config > +++ b/configs/platform-mips/barebox.config > @@ -142,9 +142,9 @@ CONFIG_IMD=y > CONFIG_CONSOLE_FULL=y > # CONFIG_CONSOLE_SIMPLE is not set > # CONFIG_CONSOLE_NONE is not set > -CONFIG_CONSOLE_ACTIVATE_FIRST=y > +# CONFIG_CONSOLE_ACTIVATE_FIRST is not set > # CONFIG_CONSOLE_ACTIVATE_ALL is not set > -# CONFIG_CONSOLE_ACTIVATE_NONE is not set > +CONFIG_CONSOLE_ACTIVATE_NONE=y > # CONFIG_CONSOLE_ALLOW_COLOR is not set > # CONFIG_PBL_CONSOLE is not set > # CONFIG_CONSOLE_RATP is not set > diff --git a/configs/platform-mipsel/barebox-malta.config.diff b/configs/platform-mipsel/barebox-malta.config.diff > index a305a002..8102eff0 100644 > --- a/configs/platform-mipsel/barebox-malta.config.diff > +++ b/configs/platform-mipsel/barebox-malta.config.diff > @@ -1,4 +1,4 @@ > -fd8ab64711e3c2bc4d260765405fff76 > +384c9ac30abd9c9b72e1ea5249e85625 > # CONFIG_AT803X_PHY is not set > CONFIG_BAREBOX_MAX_IMAGE_SIZE=0x400000 > CONFIG_BAUDRATE=38400 > @@ -42,8 +42,6 @@ CONFIG_CMD_SHA256SUM=y > CONFIG_CMD_TFTP=y > # CONFIG_COMMON_CLK is undefined > # CONFIG_COMMON_CLK_OF_PROVIDER is undefined > -# CONFIG_CONSOLE_ACTIVATE_FIRST is not set > -CONFIG_CONSOLE_ACTIVATE_NONE=y > CONFIG_CONSOLE_ALLOW_COLOR=y > # CONFIG_CPU_BIG_ENDIAN is not set > CONFIG_CPU_LITTLE_ENDIAN=y > diff --git a/configs/platform-mipsel/barebox.config b/configs/platform-mipsel/barebox.config > index 55495686..560bc9ec 100644 > --- a/configs/platform-mipsel/barebox.config > +++ b/configs/platform-mipsel/barebox.config > @@ -141,9 +141,9 @@ CONFIG_IMD=y > CONFIG_CONSOLE_FULL=y > # CONFIG_CONSOLE_SIMPLE is not set > # CONFIG_CONSOLE_NONE is not set > -CONFIG_CONSOLE_ACTIVATE_FIRST=y > +# CONFIG_CONSOLE_ACTIVATE_FIRST is not set > # CONFIG_CONSOLE_ACTIVATE_ALL is not set > -# CONFIG_CONSOLE_ACTIVATE_NONE is not set > +CONFIG_CONSOLE_ACTIVATE_NONE=y > # CONFIG_CONSOLE_ALLOW_COLOR is not set > # CONFIG_PBL_CONSOLE is not set > # CONFIG_CONSOLE_RATP is not set -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |