From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 07 Jul 2023 15:23:43 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qHlR3-001diZ-11 for lore@lore.pengutronix.de; Fri, 07 Jul 2023 15:23:43 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qHlR0-0004Gi-IP; Fri, 07 Jul 2023 15:23:42 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qHlQt-0004G0-2p; Fri, 07 Jul 2023 15:23:35 +0200 Message-ID: Date: Fri, 7 Jul 2023 15:23:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Oleksij Rempel , distrokit@pengutronix.de References: <20230707110818.3510860-1-o.rempel@pengutronix.de> <20230707110818.3510860-4-o.rempel@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20230707110818.3510860-4-o.rempel@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [DistroKit] [PATCH v2 3/7] v7a_noneon: blspec: convert to ptxdist default entries X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On 07.07.23 13:08, Oleksij Rempel wrote: > Adding new board support always included adding a special blspec package > for this new board. Most of the blspec entries are the same except for > the used devicetree blob. Since the blspec-entry package is able to the > add the barebox 'linux-appendroot true' option as well can move to the > buildin blspec-entry creation. This lowers the burden of adding new > board support since ptxdist will create a blspec entry for devicetree > each listed within the platformconfig. > > I added the 'rootwait rw' kernel command line options since most blspec > entries used these options, albeit the 'rw' support should be > reconsidered. > > Signed-off-by: Oleksij Rempel Reviewed-by: Ahmad Fatoum > --- > configs/platform-v7a_noneon/platformconfig | 7 ++++--- > .../platform-v7a_noneon/platforms/blspec-ksz9477-evb.in | 5 ----- > configs/platform-v7a_noneon/platforms/blspec-vexpress.in | 5 ----- > .../projectroot/loader/entries/sama5d3-ksz9477-evb.conf | 6 ------ > .../projectroot/loader/entries/vexpress.conf | 6 ------ > 5 files changed, 4 insertions(+), 25 deletions(-) > delete mode 100644 configs/platform-v7a_noneon/platforms/blspec-ksz9477-evb.in > delete mode 100644 configs/platform-v7a_noneon/platforms/blspec-vexpress.in > delete mode 100644 configs/platform-v7a_noneon/projectroot/loader/entries/sama5d3-ksz9477-evb.conf > delete mode 100644 configs/platform-v7a_noneon/projectroot/loader/entries/vexpress.conf > > diff --git a/configs/platform-v7a_noneon/platformconfig b/configs/platform-v7a_noneon/platformconfig > index 3ff91ce..1bedb23 100644 > --- a/configs/platform-v7a_noneon/platformconfig > +++ b/configs/platform-v7a_noneon/platformconfig > @@ -199,9 +199,10 @@ PTXCONF_BAREBOX_ARCH_STRING="arm" > # > # bootloader spec entries > # > -# PTXCONF_BLSPEC_ENTRY is not set > -PTXCONF_BLSPEC_KSZ9477_EVB=y > -PTXCONF_BLSPEC_VEXPRESS=y > +PTXCONF_BLSPEC_ENTRY=y > +PTXCONF_BLSPEC_ENTRY_DEVICETREE=y > +PTXCONF_BLSPEC_ENTRY_CMDLINE="rootwait rw" > +PTXCONF_BLSPEC_ENTRY_APPENDROOT=y > # end of bootloader spec entries > > # > diff --git a/configs/platform-v7a_noneon/platforms/blspec-ksz9477-evb.in b/configs/platform-v7a_noneon/platforms/blspec-ksz9477-evb.in > deleted file mode 100644 > index 8846209..0000000 > --- a/configs/platform-v7a_noneon/platforms/blspec-ksz9477-evb.in > +++ /dev/null > @@ -1,5 +0,0 @@ > -## SECTION=blspec > - > -config BLSPEC_KSZ9477_EVB > - tristate > - prompt "/loader/entries/sama5d3-ksz9477-evb.conf bootloader spec entry" > diff --git a/configs/platform-v7a_noneon/platforms/blspec-vexpress.in b/configs/platform-v7a_noneon/platforms/blspec-vexpress.in > deleted file mode 100644 > index 5c4f677..0000000 > --- a/configs/platform-v7a_noneon/platforms/blspec-vexpress.in > +++ /dev/null > @@ -1,5 +0,0 @@ > -## SECTION=blspec > - > -config BLSPEC_VEXPRESS > - tristate > - prompt "/loader/entries/vexpress.conf bootloader spec entry" > diff --git a/configs/platform-v7a_noneon/projectroot/loader/entries/sama5d3-ksz9477-evb.conf b/configs/platform-v7a_noneon/projectroot/loader/entries/sama5d3-ksz9477-evb.conf > deleted file mode 100644 > index 6ce491d..0000000 > --- a/configs/platform-v7a_noneon/projectroot/loader/entries/sama5d3-ksz9477-evb.conf > +++ /dev/null > @@ -1,6 +0,0 @@ > -title PTXdist - Pengutronix-DistroKit > -version 5.8 > -options rootwait rw > -linux-appendroot true > -linux /boot/zImage > -devicetree /boot/at91-sama5d3_ksz9477_evb.dtb > diff --git a/configs/platform-v7a_noneon/projectroot/loader/entries/vexpress.conf b/configs/platform-v7a_noneon/projectroot/loader/entries/vexpress.conf > deleted file mode 100644 > index a60a019..0000000 > --- a/configs/platform-v7a_noneon/projectroot/loader/entries/vexpress.conf > +++ /dev/null > @@ -1,6 +0,0 @@ > -title PTXdist - Pengutronix-DistroKit > -version 4.11 > -options rootwait rootfstype=ext4 console=ttyAMA0,115200 > -linux /boot/zImage > -devicetree /boot/vexpress-v2p-ca9.dtb > -linux-appendroot true -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |