From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 10 Dec 2025 14:09:45 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vTJwv-009v5Z-0V for lore@lore.pengutronix.de; Wed, 10 Dec 2025 14:09:45 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1vTJwu-00033i-8f; Wed, 10 Dec 2025 14:09:44 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vTJwq-00033H-Mk; Wed, 10 Dec 2025 14:09:40 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vTJwq-004xtn-1f; Wed, 10 Dec 2025 14:09:40 +0100 Received: from rsc by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1vTJwq-00Gyar-1E; Wed, 10 Dec 2025 14:09:40 +0100 Date: Wed, 10 Dec 2025 14:09:40 +0100 From: Robert Schwebel To: Michael Olbrich Message-ID: References: <20251205222320.2261758-2-rhi@pengutronix.de> <20251210121356.2492437-1-m.olbrich@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251210121356.2492437-1-m.olbrich@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [DistroKit] [PATCH] fixup! v8a: barebox-r5: clean up recipe X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Squashed. On Wed, Dec 10, 2025 at 01:13:56PM +0100, Michael Olbrich wrote: > The commit changed ':=' to '='. That is not allowed if the variable > references itself. The result is a recursion error. > > Just merge the two declarations to avoid the recursion. > --- > configs/platform-v8a/rules/barebox-r5.make | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/configs/platform-v8a/rules/barebox-r5.make b/configs/platform-v8a/rules/barebox-r5.make > index c398e46da793..2d247d4eb3ec 100644 > --- a/configs/platform-v8a/rules/barebox-r5.make > +++ b/configs/platform-v8a/rules/barebox-r5.make > @@ -48,8 +48,7 @@ BAREBOX_R5_CONF_OPT = \ > > BAREBOX_R5_MAKE_OPT = $(BAREBOX_R5_CONF_OPT) > > -BAREBOX_R5_IMAGES := images/barebox-beagleplay-r5.img > -BAREBOX_R5_IMAGES = $(addprefix $(BAREBOX_R5_BUILD_DIR)/,$(BAREBOX_R5_IMAGES)) > +BAREBOX_R5_IMAGES = $(BAREBOX_R5_BUILD_DIR)/images/barebox-beagleplay-r5.img > > ifdef PTXCONF_BAREBOX_R5 > $(BAREBOX_R5_CONFIG): > -- > 2.47.3 > > > -- Pengutronix e.K. | Dipl.-Ing. Robert Schwebel | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |