From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 18 Sep 2025 14:02:23 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uzDLD-004SVy-2A for lore@lore.pengutronix.de; Thu, 18 Sep 2025 14:02:23 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uzDLD-0003xO-1a; Thu, 18 Sep 2025 14:02:23 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uzDLB-0003we-1Y; Thu, 18 Sep 2025 14:02:21 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uzDLA-001voi-2k; Thu, 18 Sep 2025 14:02:20 +0200 Received: from rsc by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1uzDLA-00Fr1a-2K; Thu, 18 Sep 2025 14:02:20 +0200 Date: Thu, 18 Sep 2025 14:02:20 +0200 From: Robert Schwebel To: Alexander Dahl Message-ID: References: <20250918115435.205235-1-ada@thorsis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250918115435.205235-1-ada@thorsis.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [DistroKit] [PATCH] rauc-udev: Add missing comma between tokens in rules file X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leonard =?utf-8?B?R8O2aHJz?= , distrokit@pengutronix.de, Fabian Pflug Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Applied to next On Thu, Sep 18, 2025 at 01:54:35PM +0200, Alexander Dahl wrote: > `udevadm verify` threw warnings like this: > > /usr/lib/udev/rules.d/90-rauc-partitions.rules:19 style: a comma between tokens is expected. > /usr/lib/udev/rules.d/90-rauc-partitions.rules: udev rules have style issues. > > Fixes: bc056fb67ed5 ("rauc-udev: add entry for TQ MBa8MPxL board") > Fixes: 3efb9034d430 ("v8a: tqma93: Add boot_disk") > Signed-off-by: Alexander Dahl > --- > projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules b/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules > index f78c3e4..c5930c7 100644 > --- a/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules > +++ b/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules > @@ -16,8 +16,8 @@ ENV{OF_BASE_COMPATIBLE}=="*ti,am335x-bone-black*", ENV{ID_PATH}=="platform-48060 > ENV{OF_BASE_COMPATIBLE}=="*raspberrypi,3-model-b*", ENV{ID_PATH}=="platform-3f202000.mmc", TAG+="boot_disk" > ENV{OF_BASE_COMPATIBLE}=="*riot,imx6s-riotboard*", ENV{ID_PATH}=="platform-2198000.mmc", TAG+="boot_disk" > ENV{OF_BASE_COMPATIBLE}=="*radxa,rock3a*", ENV{ID_PATH}=="platform-fe2b0000.mmc", TAG+="boot_disk" > -ENV{OF_BASE_COMPATIBLE}=="*tq,imx8mp-tqma8mpql-mba8mpxl*" ENV{ID_PATH}=="platform-30b50000.mmc", TAG+="boot_disk" > -ENV{OF_BASE_COMPATIBLE}=="*tq,imx93-tqma9352-mba93xxca*" ENV{ID_PATH}=="platform-42860000.mmc", TAG+="boot_disk" > +ENV{OF_BASE_COMPATIBLE}=="*tq,imx8mp-tqma8mpql-mba8mpxl*", ENV{ID_PATH}=="platform-30b50000.mmc", TAG+="boot_disk" > +ENV{OF_BASE_COMPATIBLE}=="*tq,imx93-tqma9352-mba93xxca*", ENV{ID_PATH}=="platform-42860000.mmc", TAG+="boot_disk" > > # second part: create /dev/disk/by-usage/ symlinks > ENV{DEVTYPE}!="partition", GOTO="rauc_partitions_end" > > base-commit: 9f9ad1e35708f324f6838311dc22f5f0871a5846 > -- > 2.39.5 > > > -- Pengutronix e.K. | Dipl.-Ing. Robert Schwebel | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |