From: Robert Schwebel <r.schwebel@pengutronix.de>
To: Alexander Dahl <ada@thorsis.com>
Cc: "Leonard Göhrs" <l.goehrs@pengutronix.de>,
distrokit@pengutronix.de, "Fabian Pflug" <f.pflug@pengutronix.de>
Subject: Re: [DistroKit] [PATCH] rauc-udev: Add missing comma between tokens in rules file
Date: Thu, 18 Sep 2025 14:02:20 +0200 [thread overview]
Message-ID: <aMv0zG9cEaOsDnul@pengutronix.de> (raw)
In-Reply-To: <20250918115435.205235-1-ada@thorsis.com>
Applied to next
On Thu, Sep 18, 2025 at 01:54:35PM +0200, Alexander Dahl wrote:
> `udevadm verify` threw warnings like this:
>
> /usr/lib/udev/rules.d/90-rauc-partitions.rules:19 style: a comma between tokens is expected.
> /usr/lib/udev/rules.d/90-rauc-partitions.rules: udev rules have style issues.
>
> Fixes: bc056fb67ed5 ("rauc-udev: add entry for TQ MBa8MPxL board")
> Fixes: 3efb9034d430 ("v8a: tqma93: Add boot_disk")
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> ---
> projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules b/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules
> index f78c3e4..c5930c7 100644
> --- a/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules
> +++ b/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules
> @@ -16,8 +16,8 @@ ENV{OF_BASE_COMPATIBLE}=="*ti,am335x-bone-black*", ENV{ID_PATH}=="platform-48060
> ENV{OF_BASE_COMPATIBLE}=="*raspberrypi,3-model-b*", ENV{ID_PATH}=="platform-3f202000.mmc", TAG+="boot_disk"
> ENV{OF_BASE_COMPATIBLE}=="*riot,imx6s-riotboard*", ENV{ID_PATH}=="platform-2198000.mmc", TAG+="boot_disk"
> ENV{OF_BASE_COMPATIBLE}=="*radxa,rock3a*", ENV{ID_PATH}=="platform-fe2b0000.mmc", TAG+="boot_disk"
> -ENV{OF_BASE_COMPATIBLE}=="*tq,imx8mp-tqma8mpql-mba8mpxl*" ENV{ID_PATH}=="platform-30b50000.mmc", TAG+="boot_disk"
> -ENV{OF_BASE_COMPATIBLE}=="*tq,imx93-tqma9352-mba93xxca*" ENV{ID_PATH}=="platform-42860000.mmc", TAG+="boot_disk"
> +ENV{OF_BASE_COMPATIBLE}=="*tq,imx8mp-tqma8mpql-mba8mpxl*", ENV{ID_PATH}=="platform-30b50000.mmc", TAG+="boot_disk"
> +ENV{OF_BASE_COMPATIBLE}=="*tq,imx93-tqma9352-mba93xxca*", ENV{ID_PATH}=="platform-42860000.mmc", TAG+="boot_disk"
>
> # second part: create /dev/disk/by-usage/ symlinks
> ENV{DEVTYPE}!="partition", GOTO="rauc_partitions_end"
>
> base-commit: 9f9ad1e35708f324f6838311dc22f5f0871a5846
> --
> 2.39.5
>
>
>
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
prev parent reply other threads:[~2025-09-18 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 11:54 Alexander Dahl
2025-09-18 12:02 ` Robert Schwebel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMv0zG9cEaOsDnul@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=ada@thorsis.com \
--cc=distrokit@pengutronix.de \
--cc=f.pflug@pengutronix.de \
--cc=l.goehrs@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox