From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 12 Jul 2024 16:30:52 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sSHIS-0047Ye-2L for lore@lore.pengutronix.de; Fri, 12 Jul 2024 16:30:52 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sSHIS-0007U9-Av; Fri, 12 Jul 2024 16:30:52 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sSHIL-0007Tt-Mv; Fri, 12 Jul 2024 16:30:45 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sSHIL-0091Ih-AT; Fri, 12 Jul 2024 16:30:45 +0200 Received: from rsc by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sSHIL-00CKsO-0i; Fri, 12 Jul 2024 16:30:45 +0200 Date: Fri, 12 Jul 2024 16:30:45 +0200 From: Robert Schwebel To: Ahmad Fatoum Message-ID: References: <20240711110143.470379-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240711110143.470379-1-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [DistroKit] [PATCH 1/4] v7a: barebox: enable ARM accelerated SHA1 routines X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false series applied to next On Thu, Jul 11, 2024 at 01:01:40PM +0200, Ahmad Fatoum wrote: > All barebox defconfigs that enable generic SHA1 support also enable > ARM-optimized SHA256 support. Enable ARM-optimized SHA1 as well for > improved performance. > > It would be nice if we could disable generic SHA1 now, but that's not > possible yet, because generic SHA1 support is selected by > CONFIG_CMD_SHA1SUM, which we enable. > > Signed-off-by: Ahmad Fatoum > --- > configs/platform-v7a/barebox-am335x.config | 2 +- > configs/platform-v7a/barebox-am335x.config.diff | 2 +- > configs/platform-v7a/barebox-at91.config | 2 +- > configs/platform-v7a/barebox-at91.config.diff | 2 +- > configs/platform-v7a/barebox-mx6.config | 2 +- > configs/platform-v7a/barebox-mx6.config.diff | 2 +- > configs/platform-v7a/barebox-rpi2.config | 2 +- > configs/platform-v7a/barebox-rpi2.config.diff | 2 +- > configs/platform-v7a/barebox-stm32mp.config | 2 +- > configs/platform-v7a/barebox-stm32mp.config.diff | 2 +- > configs/platform-v7a/barebox-vexpress.config | 2 +- > configs/platform-v7a/barebox-vexpress.config.diff | 2 +- > configs/platform-v7a/barebox.config | 2 +- > 13 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/configs/platform-v7a/barebox-am335x.config b/configs/platform-v7a/barebox-am335x.config > index aeaf1192bdbb..61c17f70896d 100644 > --- a/configs/platform-v7a/barebox-am335x.config > +++ b/configs/platform-v7a/barebox-am335x.config > @@ -1038,7 +1038,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y > # CONFIG_DIGEST_SHA384_GENERIC is not set > # CONFIG_DIGEST_SHA512_GENERIC is not set > CONFIG_DIGEST_HMAC_GENERIC=y > -# CONFIG_DIGEST_SHA1_ARM is not set > +CONFIG_DIGEST_SHA1_ARM=y > CONFIG_DIGEST_SHA256_ARM=y > CONFIG_CRYPTO_KEYSTORE=y > # end of Crypto support > diff --git a/configs/platform-v7a/barebox-am335x.config.diff b/configs/platform-v7a/barebox-am335x.config.diff > index 8c6e7959fedf..f1d46b41cf9a 100644 > --- a/configs/platform-v7a/barebox-am335x.config.diff > +++ b/configs/platform-v7a/barebox-am335x.config.diff > @@ -1,4 +1,4 @@ > -dcf5e1fcb2504dfaa2c1441bc71bbdd2 > +e68dcd40a22e40e08bfbabe8f90da935 > # CONFIG_AM33XX_NET_BOOT is not set > CONFIG_ARCH_AM33XX=y > # CONFIG_ARCH_BCM283X is not set > diff --git a/configs/platform-v7a/barebox-at91.config b/configs/platform-v7a/barebox-at91.config > index dec985bc8a9e..c3aeee7125fe 100644 > --- a/configs/platform-v7a/barebox-at91.config > +++ b/configs/platform-v7a/barebox-at91.config > @@ -1042,7 +1042,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y > # CONFIG_DIGEST_SHA384_GENERIC is not set > # CONFIG_DIGEST_SHA512_GENERIC is not set > # CONFIG_DIGEST_HMAC_GENERIC is not set > -# CONFIG_DIGEST_SHA1_ARM is not set > +CONFIG_DIGEST_SHA1_ARM=y > CONFIG_DIGEST_SHA256_ARM=y > # CONFIG_CRYPTO_KEYSTORE is not set > # end of Crypto support > diff --git a/configs/platform-v7a/barebox-at91.config.diff b/configs/platform-v7a/barebox-at91.config.diff > index 9ebfb4771860..2aca21897016 100644 > --- a/configs/platform-v7a/barebox-at91.config.diff > +++ b/configs/platform-v7a/barebox-at91.config.diff > @@ -1,4 +1,4 @@ > -dcf5e1fcb2504dfaa2c1441bc71bbdd2 > +e68dcd40a22e40e08bfbabe8f90da935 > CONFIG_ARCH_AT91=y > # CONFIG_ARCH_BCM283X is not set > # CONFIG_ARCH_IMX is undefined > diff --git a/configs/platform-v7a/barebox-mx6.config b/configs/platform-v7a/barebox-mx6.config > index 945b4a903463..2a144c674e0a 100644 > --- a/configs/platform-v7a/barebox-mx6.config > +++ b/configs/platform-v7a/barebox-mx6.config > @@ -1226,7 +1226,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y > # CONFIG_DIGEST_SHA384_GENERIC is not set > # CONFIG_DIGEST_SHA512_GENERIC is not set > CONFIG_DIGEST_HMAC_GENERIC=y > -# CONFIG_DIGEST_SHA1_ARM is not set > +CONFIG_DIGEST_SHA1_ARM=y > CONFIG_DIGEST_SHA256_ARM=y > CONFIG_CRYPTO_KEYSTORE=y > # end of Crypto support > diff --git a/configs/platform-v7a/barebox-mx6.config.diff b/configs/platform-v7a/barebox-mx6.config.diff > index af14a2eed749..291a35edc4b9 100644 > --- a/configs/platform-v7a/barebox-mx6.config.diff > +++ b/configs/platform-v7a/barebox-mx6.config.diff > @@ -1,4 +1,4 @@ > -dcf5e1fcb2504dfaa2c1441bc71bbdd2 > +e68dcd40a22e40e08bfbabe8f90da935 > # CONFIG_ARCH_BCM283X is not set > CONFIG_ARCH_HAS_FEC_IMX=y > CONFIG_ARCH_HAS_IMX_GPT=y > diff --git a/configs/platform-v7a/barebox-rpi2.config b/configs/platform-v7a/barebox-rpi2.config > index b00b8f7b29a5..63035910c2a3 100644 > --- a/configs/platform-v7a/barebox-rpi2.config > +++ b/configs/platform-v7a/barebox-rpi2.config > @@ -1008,7 +1008,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y > # CONFIG_DIGEST_SHA384_GENERIC is not set > # CONFIG_DIGEST_SHA512_GENERIC is not set > # CONFIG_DIGEST_HMAC_GENERIC is not set > -# CONFIG_DIGEST_SHA1_ARM is not set > +CONFIG_DIGEST_SHA1_ARM=y > CONFIG_DIGEST_SHA256_ARM=y > # CONFIG_CRYPTO_KEYSTORE is not set > # end of Crypto support > diff --git a/configs/platform-v7a/barebox-rpi2.config.diff b/configs/platform-v7a/barebox-rpi2.config.diff > index 82fa555afacc..b2b34df1d863 100644 > --- a/configs/platform-v7a/barebox-rpi2.config.diff > +++ b/configs/platform-v7a/barebox-rpi2.config.diff > @@ -1,4 +1,4 @@ > -dcf5e1fcb2504dfaa2c1441bc71bbdd2 > +e68dcd40a22e40e08bfbabe8f90da935 > CONFIG_ARM_ASM_UNIFIED=y > # CONFIG_CMD_NVMEM is not set > CONFIG_DRIVER_NET_BCMGENET=y > diff --git a/configs/platform-v7a/barebox-stm32mp.config b/configs/platform-v7a/barebox-stm32mp.config > index 898d8ed979c3..afba652187a9 100644 > --- a/configs/platform-v7a/barebox-stm32mp.config > +++ b/configs/platform-v7a/barebox-stm32mp.config > @@ -990,7 +990,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y > # CONFIG_DIGEST_SHA384_GENERIC is not set > # CONFIG_DIGEST_SHA512_GENERIC is not set > CONFIG_DIGEST_HMAC_GENERIC=y > -# CONFIG_DIGEST_SHA1_ARM is not set > +CONFIG_DIGEST_SHA1_ARM=y > CONFIG_DIGEST_SHA256_ARM=y > # CONFIG_CRYPTO_KEYSTORE is not set > # end of Crypto support > diff --git a/configs/platform-v7a/barebox-stm32mp.config.diff b/configs/platform-v7a/barebox-stm32mp.config.diff > index 1d31bc529248..be07a2a27b1f 100644 > --- a/configs/platform-v7a/barebox-stm32mp.config.diff > +++ b/configs/platform-v7a/barebox-stm32mp.config.diff > @@ -1,4 +1,4 @@ > -dcf5e1fcb2504dfaa2c1441bc71bbdd2 > +e68dcd40a22e40e08bfbabe8f90da935 > # CONFIG_ARCH_BCM283X is not set > CONFIG_ARCH_HAS_RESET_CONTROLLER=y > CONFIG_ARCH_NR_GPIO=416 > diff --git a/configs/platform-v7a/barebox-vexpress.config b/configs/platform-v7a/barebox-vexpress.config > index 2c45042c62b7..ac4bff2d9a9d 100644 > --- a/configs/platform-v7a/barebox-vexpress.config > +++ b/configs/platform-v7a/barebox-vexpress.config > @@ -949,7 +949,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y > # CONFIG_DIGEST_SHA384_GENERIC is not set > # CONFIG_DIGEST_SHA512_GENERIC is not set > # CONFIG_DIGEST_HMAC_GENERIC is not set > -# CONFIG_DIGEST_SHA1_ARM is not set > +CONFIG_DIGEST_SHA1_ARM=y > CONFIG_DIGEST_SHA256_ARM=y > # CONFIG_CRYPTO_KEYSTORE is not set > # end of Crypto support > diff --git a/configs/platform-v7a/barebox-vexpress.config.diff b/configs/platform-v7a/barebox-vexpress.config.diff > index a5f70ff8f594..103a9e77df62 100644 > --- a/configs/platform-v7a/barebox-vexpress.config.diff > +++ b/configs/platform-v7a/barebox-vexpress.config.diff > @@ -1,4 +1,4 @@ > -dcf5e1fcb2504dfaa2c1441bc71bbdd2 > +e68dcd40a22e40e08bfbabe8f90da935 > CONFIG_AMBA_SP804=y > # CONFIG_ARCH_BCM283X is not set > CONFIG_ARCH_VEXPRESS=y > diff --git a/configs/platform-v7a/barebox.config b/configs/platform-v7a/barebox.config > index e678fff7e57b..a562d8e8bf73 100644 > --- a/configs/platform-v7a/barebox.config > +++ b/configs/platform-v7a/barebox.config > @@ -1002,7 +1002,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y > # CONFIG_DIGEST_SHA384_GENERIC is not set > # CONFIG_DIGEST_SHA512_GENERIC is not set > # CONFIG_DIGEST_HMAC_GENERIC is not set > -# CONFIG_DIGEST_SHA1_ARM is not set > +CONFIG_DIGEST_SHA1_ARM=y > CONFIG_DIGEST_SHA256_ARM=y > # CONFIG_CRYPTO_KEYSTORE is not set > # end of Crypto support > -- > 2.39.2 > > > -- Pengutronix e.K. | Dipl.-Ing. Robert Schwebel | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |